Skip metadata assignment for untyped divisions

Prevent metadata from being written to structural container nodes
of type page without a TYPE. Recursion is preserved, but only semantic divisions
receive metadata. Fixes unintended DMDSEC creation.

Author: BartChris

Kitodo/src/main/java/org/kitodo/production/helper/ProcessHelper.java

@@ -460,14 +460,17 @@ public static void setMetadataDomain(Metadata metadata, RulesetManagementInterfa
     public static void addAllowedMetadataRecursive(Division<?> division, Collection<String> keys, String value,
                                                    RulesetManagementInterface rulesetManagement, String acquisitionStage,
                                                    List<Locale.LanguageRange> priorityList) {
-        StructuralElementViewInterface divisionView = rulesetManagement.getStructuralElementView(division.getType(),
-                acquisitionStage, priorityList);
-        for (MetadataViewInterface metadataView : divisionView.getAllowedMetadata()) {
-            if (metadataView instanceof SimpleMetadataViewInterface && keys.contains(metadataView.getId())
-                    && division.getMetadata().parallelStream()
-                    .filter(metadata -> metadataView.getId().equals(metadata.getKey()))
-                    .count() < metadataView.getMaxOccurs()) {
-                MetadataEditor.writeMetadataEntry(division, (SimpleMetadataViewInterface) metadataView, value);
+        String type = division.getType();
+        if (Objects.nonNull(type) && !type.isEmpty()) {
+            StructuralElementViewInterface divisionView = rulesetManagement.getStructuralElementView(type,
+                    acquisitionStage, priorityList);
+            for (MetadataViewInterface metadataView : divisionView.getAllowedMetadata()) {
+                if (metadataView instanceof SimpleMetadataViewInterface && keys.contains(metadataView.getId())
+                        && division.getMetadata().parallelStream()
+                        .filter(metadata -> metadataView.getId().equals(metadata.getKey()))
+                        .count() < metadataView.getMaxOccurs()) {
+                    MetadataEditor.writeMetadataEntry(division, (SimpleMetadataViewInterface) metadataView, value);
+                }
             }
         }
         for (Division<?> child : division.getChildren()) {
@@ -510,8 +513,6 @@ private static void setProcessTitleMetadata(Workpiece workpiece, String processT
         if (!processTitleKeys.isEmpty()) {
             ProcessHelper.addAllowedMetadataRecursive(workpiece.getLogicalStructure(), processTitleKeys, processTitle,
                     rulesetManagement, acquisitionStage, priorityList);
-            ProcessHelper.addAllowedMetadataRecursive(workpiece.getPhysicalStructure(), processTitleKeys, processTitle,
-                    rulesetManagement, acquisitionStage, priorityList);
         }
     }