Skip to content

Commit fdc4db9

Browse files
committed
Refactor for checkstyle
1 parent ecfc717 commit fdc4db9

2 files changed

Lines changed: 13 additions & 7 deletions

File tree

Kitodo/src/main/java/org/kitodo/production/forms/createprocess/ProcessFieldedMetadata.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -674,12 +674,7 @@ void markLeadingMetadataFields(List<Map<MetadataEntry, Boolean>> leadingMetadata
674674
public void preserve() throws InvalidMetadataValueException, NoSuchMetadataFieldException {
675675
try {
676676
boolean untyped = isDivisionUntyped();
677-
678-
if (Objects.nonNull(division)) {
679-
division.getContentIds().clear();
680-
division.setOrderlabel(null);
681-
division.setLabel(null);
682-
}
677+
resetDivision();
683678
metadata.clear();
684679
for (TreeNode<Object> child : treeNode.getChildren()) {
685680
ProcessDetail row = (ProcessDetail) child.getData();
@@ -724,6 +719,17 @@ public void preserve() throws InvalidMetadataValueException, NoSuchMetadataField
724719
}
725720
}
726721

722+
private void resetDivision() {
723+
if (Objects.nonNull(division)) {
724+
division.getContentIds().clear();
725+
division.setOrderlabel(null);
726+
division.setLabel(null);
727+
}
728+
}
729+
730+
/**
731+
* Restricts the visible metadata fields of this element to structural metadata only.
732+
*/
727733
public void filterToStructuralFields() {
728734
treeNode.getChildren().removeIf(child -> {
729735
ProcessDetail row = (ProcessDetail) child.getData();

Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/MetadataPanel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ void showLogical(Optional<LogicalDivision> optionalStructure) {
152152
logicalMetadataTable = createProcessFieldedMetadata(optionalStructure.get());
153153

154154
if (isDivisionUntyped(optionalStructure.get())) {
155-
logicalMetadataTable.filterToStructuralFields(); // 👈 NEW
155+
logicalMetadataTable.filterToStructuralFields();
156156
}
157157

158158
dataEditorForm.getAddMetadataDialog().prepareAddableMetadataForStructure(

0 commit comments

Comments
 (0)