Update workflow editor to v2.1.0 (translated UI, refreshed look, remove redundant descriptions)#6928
Open
Erikmitk wants to merge 4 commits into
Open
Update workflow editor to v2.1.0 (translated UI, refreshed look, remove redundant descriptions)#6928Erikmitk wants to merge 4 commits into
Erikmitk wants to merge 4 commits into
Conversation
Member
Author
|
@solth Once we get this approved and merged I'd like to mark this as the point of transferring the editor repo into the Kitodo organization. It lives in my personal space but it is an integral part of Kitodo.Production. So it seems wrong that the code is detached from the org. I can still keep it up-to-date but probably need the appropriate permissions after the move. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the embedded workflow editor (bpmn-js customization) to version 2.1.0 and resolves two long-standing UX issues with the editor's UI strings and property panel.
The editor source and full changelog are available at: https://github.com/Erikmitk/kitodo-workflow-editor/releases/tag/v2.1.0
Changes
Translation of palette and context pad tooltips (closes #3654)
Palette tooltips (e.g. "Append Gateway", "Create Start Event") and context pad action labels are now translated into German and English. Language is detected from
document.body.langrather than a hidden input, making detection reliable regardless of JSF render order. Spanish (es) support is also included.Removal of redundant property descriptions (closes #4786)
The "Documentation" group, which contained redundant and inconsistently applied descriptions for only two task properties ("Metadata" and "Automatic"), has been removed from the properties panel entirely.
Additional fixes
textNode.nodeValuepatching to preserve React's internal Text node references)getLocalizedStringForKeyhardened against timing edge cases during initialisationFiles changed
Kitodo/src/main/webapp/WEB-INF/resources/js/modeler_custom.js— language detection and localisation helperKitodo/src/main/webapp/WEB-INF/resources/js/modeler_min.js— updated minified editor bundle (v2.1.0)Kitodo/src/main/webapp/WEB-INF/resources/css/modeler.css— updated editor stylesheetKitodo/src/main/webapp/WEB-INF/resources/font/— BPMN icon font files (new)