Refactor: decouple ExportDms from ExportMets #6955
Draft
BartChris wants to merge 1 commit into
Draft
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -10 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // validate metadata | ||
| if (ConfigCore.getBooleanParameterOrDefaultValue(ParameterCore.USE_META_DATA_VALIDATION) | ||
| && !ServiceManager.getMetadataValidationService().validate(gdzfile, this.myPrefs)) { | ||
| && !ServiceManager.getMetadataValidationService().validate(gdzfile, prefs)) { |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| LegacyMetsModsDigitalDocumentHelper gdzfile; | ||
| try { | ||
| gdzfile = new LegacyMetsModsDigitalDocumentHelper(this.myPrefs.getRuleset()); | ||
| gdzfile = new LegacyMetsModsDigitalDocumentHelper(prefs.getRuleset()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| LegacyMetsModsDigitalDocumentHelper gdzfile; | ||
| try { | ||
| gdzfile = new LegacyMetsModsDigitalDocumentHelper(this.myPrefs.getRuleset()); | ||
| gdzfile = new LegacyMetsModsDigitalDocumentHelper(prefs.getRuleset()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
BartChris
force-pushed
the
export_mets_refactor
branch
from
dcb1dce to
3f54dc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExportDmscurrently extendsExportMets, introducing unnecessary coupling that makes further refactoring of the DMS export logic difficult.This PR removes the inheritance relationship and refactors the code so that
ExportDmsusesExportMetsvia composition instead. In addition, thestartExportmethods inExportMetsare removed, as they contributed to confusion about the relationship between both classes.A dedicated
MetsExportServiceis introduced to handle orchestration concerns (e.g. resolving user home, preparing directories, loading metadata), whileExportMetsis reduced to a focused helper for writing METS files.