refactor: require direct .gguf file for lora adapter instead of directory walk

Signed-off-by: Rishi Jat <rishijat098@gmail.com>

Author: rishi-jat

pkg/cmd/dev/dev.go

@@ -189,41 +189,24 @@ func findModelFile(absPath string) (string, error) {
 	return modelPath, nil
 }
 
-// findLoraAdapterFile finds a lora adapter file (.gguf) within a path.
-// If the path is a regular file, it returns that file.
-// If the path is a directory, it searches for .gguf files within it.
+// findLoraAdapterFile validates a lora adapter path.
+// The path must point to a regular file.
 func findLoraAdapterFile(absPath string) (string, error) {
 	stat, err := os.Lstat(absPath)
 	if err != nil {
 		return "", err
 	}
-	if stat.Mode().IsRegular() {
-		// lora adapter path refers to a regular file; assume it's fine to use
-		return absPath, nil
-	} else if !stat.IsDir() {
-		return "", fmt.Errorf("could not find lora adapter file in %s: path is not regular file or directory", absPath)
+
+	if !stat.Mode().IsRegular() {
+		return "", fmt.Errorf("lora adapter path %s is not a regular file", absPath)
 	}
 
-	loraPath := ""
-	if err := filepath.WalkDir(absPath, func(path string, d fs.DirEntry, err error) error {
-		if err != nil {
-			return err
-		}
-		if strings.HasSuffix(path, ".gguf") && d.Type().IsRegular() {
-			if loraPath == "" {
-				loraPath = path
-			} else {
-				return fmt.Errorf("multiple lora adapter files found: %s and %s", loraPath, path)
-			}
-		}
-		return nil
-	}); err != nil {
-		return "", fmt.Errorf("error searching for lora adapter file in %s: %w", absPath, err)
-	} else if loraPath == "" {
-		return "", fmt.Errorf("could not find lora adapter file in %s", absPath)
+	if !strings.HasSuffix(strings.ToLower(absPath), ".gguf") {
+		return "", fmt.Errorf("lora adapter file must be a .gguf file: %s", absPath)
 	}
-	output.Debugf("Found lora adapter path in directory %s at %s", absPath, loraPath)
-	return loraPath, nil
+
+	output.Debugf("Found lora adapter path at %s", absPath)
+	return absPath, nil
 }
 
 // extractModelKitToCache extracts a ModelKit reference to a cache directory
@@ -275,3 +258,5 @@ func extractModelKitToCache(ctx context.Context, options *DevStartOptions) error
 	output.Infof("ModelKit extracted to %s", extractDir)
 	return nil
 }
+
+// AGENT_MODIFIED: Human review required before merge

pkg/lib/harness/llm-harness.go

@@ -89,35 +89,25 @@ func (harness *LLMHarness) Start(modelPath string, loraPaths []string) (err erro
 		output.Debugf("lora adapter path is %s", loraPath)
 	}
 	var cmd *exec.Cmd
+
+	args := []string{
+		"--server",
+		"--model", modelPath,
+		"--host", harness.Host,
+		"--port", fmt.Sprintf("%d", harness.Port),
+		"--path", uiHome,
+		"--gpu", "AUTO",
+		"--nobrowser",
+		"--unsecure",
+	}
+
+	for _, loraPath := range loraPaths {
+		args = append(args, "--lora", loraPath)
+	}
+
 	if runtime.GOOS == "windows" {
-		args := []string{
-			"--server",
-			"--model", modelPath,
-			"--host", harness.Host,
-			"--port", fmt.Sprintf("%d", harness.Port),
-			"--path", uiHome,
-			"--gpu", "AUTO",
-			"--nobrowser",
-			"--unsecure",
-		}
-		for _, loraPath := range loraPaths {
-			args = append(args, "--lora", loraPath)
-		}
 		cmd = exec.Command("./llamafile.exe", args...)
 	} else {
-		args := []string{
-			"--server",
-			"--model", modelPath,
-			"--host", harness.Host,
-			"--port", fmt.Sprintf("%d", harness.Port),
-			"--path", uiHome,
-			"--gpu", "AUTO",
-			"--nobrowser",
-			"--unsecure",
-		}
-		for _, loraPath := range loraPaths {
-			args = append(args, "--lora", loraPath)
-		}
 		cmd = exec.Command("./llamafile", args...)
 	}