Skip to content

Commit 38a450d

Browse files
removed irrelivent commits in test_file
Signed-off-by: maishivamhoo123 <maishivamhoo@gmail.com>
1 parent 17f67a8 commit 38a450d

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

pkg/lib/filter/filter_test.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ func TestParseFilter_EdgeCases(t *testing.T) {
9696
require.NoError(t, err)
9797
require.NotNil(t, result)
9898

99-
// Verify base types
10099
if tt.expectedTypes != nil {
101100
assert.Equal(t, tt.expectedTypes, result.BaseTypes)
102101
}
@@ -105,7 +104,6 @@ func TestParseFilter_EdgeCases(t *testing.T) {
105104
if tt.expectedFilters != nil {
106105
assert.Equal(t, tt.expectedFilters, result.Filters)
107106
} else {
108-
// If no specific filters expected, should be empty
109107
assert.Empty(t, result.Filters)
110108
}
111109
})
@@ -188,7 +186,7 @@ func TestKitfileMatches(t *testing.T) {
188186
{Path: "prompts/pdf-processing.txt"},
189187
{Path: "prompts/greeting.txt"},
190188
},
191-
DataSets: []artifact.DataSet{ // Note: Check if your struct uses DataSets or Datasets
189+
DataSets: []artifact.DataSet{
192190
{Path: "data/train.csv"},
193191
},
194192
}
@@ -231,7 +229,7 @@ func TestKitfileMatches(t *testing.T) {
231229
{
232230
name: "Fails gracefully on nil Kitfile",
233231
filterStrings: []string{"model"},
234-
expected: false, // Handled specially in the test loop below
232+
expected: false,
235233
},
236234
}
237235

@@ -244,7 +242,6 @@ func TestKitfileMatches(t *testing.T) {
244242
filters = append(filters, *conf)
245243
}
246244

247-
// Test edge case: nil kitfile
248245
if tt.name == "Fails gracefully on nil Kitfile" {
249246
result := KitfileMatches(nil, filters)
250247
assert.Equal(t, tt.expected, result)

0 commit comments

Comments
 (0)