Skip to content

Fix #1138: Set org.opencontainers.image.created annotation on ModelKit manifests #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itniuma2026 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix #1138: Set org.opencontainers.image.created annotation on ModelKit manifests #1139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92e85bb
fix: Set org.opencontainers.image.created annotation on ModelKit mani…
itniuma2026 Mar 25, 2026
f140076
fix: move AnnotationCreated to createManifest per review
itniuma2026 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/lib/filesystem/local-storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"errors"
"fmt"
"os"
"time"

"github.com/kitops-ml/kitops/pkg/artifact"
"github.com/kitops-ml/kitops/pkg/lib/constants"
Expand Down Expand Up @@ -345,6 +346,7 @@ func createManifest(configDesc ocispec.Descriptor, layerDescs []ocispec.Descript
manifest.Annotations = map[string]string{}
}
manifest.Annotations[constants.CliVersionAnnotation] = constants.Version
manifest.Annotations[ocispec.AnnotationCreated] = time.Now().UTC().Format(time.RFC3339)

Comment on lines 348 to 350
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.opencontainers.image.created is being set using a fresh time.Now() call here, which can diverge from the creation timestamp stored in the config blob (e.g., ModelPack config sets CreatedAt separately and currently uses non-UTC time). This can lead to inconsistent "created" times between manifest and config. Consider generating a single UTC timestamp once during pack and reusing it for both config creation and this manifest annotation (or deriving the manifest value from the config’s CreatedAt when available).

Copilot uses AI. Check for mistakes.
return manifest, nil
}