Skip to content

Commit 2188782

Browse files
committed
✅ tests: drop stale setuptools assertion
setuptools was added to setup.py install_reqs in #3007 (May 2024), so it now appears as a direct (non-recursive) dependency. The assertion at test_pythonpackage.py:46 ("setuptools not in deps_nonrecursive") has been wrong since then but went unnoticed because the file is skipped in CI (`make test` uses `--ignore tests/test_pythonpackage.py`). The remaining `include_build_requirements=True` assertion still exercises the build-deps code path. Note this test is skipped by the CI but was ran manually upon during pre-release checks. This can be reproduced via: ``` pytest tests/test_pythonpackage.py::test_get_package_dependencies ``` The error was: ```` > assert "setuptools" not in deps_nonrecursive E AssertionError: assert 'setuptools' not in {'appdirs', 'build', 'colorama>=0.3.3', 'jinja2', 'meson', 'ninja', ...} ```
1 parent e928129 commit 2188782

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

tests/test_pythonpackage.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,8 @@ def test_get_package_dependencies():
4141
dep for dep in deps_recursive
4242
if "MarkupSafe" in dep
4343
]
44-
# Check setuptools not being in non-recursive deps:
45-
# (It will be in recursive ones due to p4a's build dependency)
46-
assert "setuptools" not in deps_nonrecursive
47-
# Check setuptools is present in non-recursive deps,
48-
# if we also add build requirements:
44+
# Check setuptools is present in non-recursive deps when we add
45+
# build requirements:
4946
assert "setuptools" in get_package_dependencies(
5047
local_repo_folder(), recursive=False,
5148
include_build_requirements=True,

0 commit comments

Comments
 (0)