Commit 2188782
committed
✅ tests: drop stale setuptools assertion
setuptools was added to setup.py install_reqs in #3007 (May 2024),
so it now appears as a direct (non-recursive) dependency. The
assertion at test_pythonpackage.py:46 ("setuptools not in
deps_nonrecursive") has been wrong since then but went unnoticed
because the file is skipped in CI (`make test` uses
`--ignore tests/test_pythonpackage.py`).
The remaining `include_build_requirements=True` assertion still
exercises the build-deps code path.
Note this test is skipped by the CI but was ran manually upon during
pre-release checks. This can be reproduced via:
```
pytest tests/test_pythonpackage.py::test_get_package_dependencies
```
The error was:
````
> assert "setuptools" not in deps_nonrecursive
E AssertionError: assert 'setuptools' not in {'appdirs', 'build', 'colorama>=0.3.3', 'jinja2', 'meson', 'ninja', ...}
```1 parent e928129 commit 2188782
1 file changed
Lines changed: 2 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
| 44 | + | |
| 45 | + | |
49 | 46 | | |
50 | 47 | | |
51 | 48 | | |
| |||
0 commit comments