chore(ci): update windows script

Author: kjdev

.github/workflows/build.ps1

@@ -2,12 +2,50 @@ $ErrorActionPreference = "Stop"
 
 $env:PATH = "C:\php\devel;C:\php\bin;C:\php\deps\bin;$env:PATH"
 
+# Toolset
+# $installerDir = Join-Path "${env:ProgramFiles(x86)}\Microsoft Visual Studio" 'Installer'
+# $vswherePath = Join-Path $installerDir 'vswhere.exe'
+# if (-not (Test-Path $vswherePath)) {
+#     if (-not (Test-Path $installerDir)) {
+#         New-Item -Path $installerDir -ItemType Directory -Force | Out-Null
+#     }
+#     $vsWhereUrl = 'https://github.com/microsoft/vswhere/releases/latest/download/vswhere.exe'
+#     Invoke-WebRequest -Uri $vsWhereUrl -OutFile $vswherePath -UseBasicParsing
+# }
+# if($null -eq (Get-Command vswhere -ErrorAction SilentlyContinue)) {
+#     throw "vswhere is not available"
+# }
+$MSVCDirectory = vswhere -latest -products * -find "VC\Tools\MSVC"
+$selectedToolset = $null
+$minor = $null
+foreach ($toolset in (Get-ChildItem $MSVCDirectory)) {
+    $toolsetMajorVersion, $toolsetMinorVersion = $toolset.Name.split(".")[0,1]
+    $major = 14
+    switch ($env:VS) {
+        'vs17' { $minorMin = 30; $minorMax = $null; break }
+        'vs16' { $minorMin = 20; $minorMax = 29; break }
+        Default { throw "VS version is not available" }
+    }
+    $majorVersionCheck = [int]$major -eq [int]$toolsetMajorVersion
+    $minorLowerBoundCheck = [int]$toolsetMinorVersion -ge [int]$minorMin
+    $minorUpperBoundCheck = ($null -eq $minorMax) -or ([int]$toolsetMinorVersion -le [int]$minorMax)
+    if ($majorVersionCheck -and $minorLowerBoundCheck -and $minorUpperBoundCheck) {
+        if($null -eq $minor -or [int]$toolsetMinorVersion -gt [int]$minor) {
+            $selectedToolset = $toolset.Name.Trim()
+            $minor = $toolsetMinorVersion
+        }
+    }
+}
+if (-not $selectedToolset) {
+    throw "toolset not available"
+}
+
 $task = New-Item 'task.bat' -Force
 Add-Content $task 'call phpize 2>&1'
 Add-Content $task "call configure --with-php-build=C:\php\deps --enable-$env:PHP_EXT --enable-debug-pack 2>&1"
 Add-Content $task 'nmake /nologo 2>&1'
 Add-Content $task 'exit %errorlevel%'
-& "C:\php\php-sdk-$env:BIN_SDK_VER\phpsdk-$env:VS-$env:ARCH.bat" -t $task
+& "C:\php\php-sdk-$env:BIN_SDK_VER\phpsdk-starter.bat" -c $env:VS -a $env:ARCH -s $selectedToolset -t $task
 if (-not $?) {
     throw "building failed with errorlevel $LastExitCode"
 }

.github/workflows/install.ps1

@@ -72,10 +72,12 @@ if (-not (Test-Path "C:\php\bin")) {
     Expand-Archive "C:\php\$bname" "C:\php\bin"
 }
 
-# # library dependency: "C:\php\deps"
-# $bname = "$env:DEP-$env:VS-$env:ARCH.zip"
-# if (-not (Test-Path "C:\php\$bname")) {
-#     echo "Download: https://windows.php.net/downloads/pecl/deps/$bname"
-#     Invoke-WebRequest "https://windows.php.net/downloads/pecl/deps/$bname" -OutFile "C:\php\$bname"
-#     Expand-Archive "C:\php\$bname" 'C:\php\deps'
-# }
+# library dependency: "C:\php\deps"
+if ("$env:DEP" -ne "") {
+    $bname = "$env:DEP-$env:VS-$env:ARCH.zip"
+    if (-not (Test-Path "C:\php\$bname")) {
+        echo "Download: https://windows.php.net/downloads/pecl/deps/$bname"
+        Invoke-WebRequest "https://windows.php.net/downloads/pecl/deps/$bname" -OutFile "C:\php\$bname"
+        Expand-Archive "C:\php\$bname" "C:\php\deps"
+    }
+}

.github/workflows/test.ps1

@@ -3,7 +3,7 @@ $ErrorActionPreference = "Stop"
 $env:PATH = "C:\php\devel;C:\php\bin;C:\php\deps\bin;$env:PATH"
 
 $env:TEST_PHP_EXECUTABLE = "C:\php\bin\php.exe"
-& $env:TEST_PHP_EXECUTABLE 'run-tests.php' --show-diff tests
+& $env:TEST_PHP_EXECUTABLE 'run-tests.php' --color --show-diff tests
 if (-not $?) {
     throw "testing failed with errorlevel $LastExitCode"
 }

.github/workflows/windows.yaml

@@ -8,7 +8,7 @@ on:
 env:
   PHP_EXT: snappy
   PHP_EXT_VERSION: ${{ github.event.release.tag_name }}
-  BIN_SDK_VER: 2.3.0
+  BIN_SDK_VER: 2.5.0
 
 jobs:
   ci: