fix: simplify output handler context start by removing intermediate variable and adding compression coding check

kjdev · kjdev · commit 1fb430ba46b7 · 2025-08-08T10:47:22.000+09:00
diff --git a/zstd.c b/zstd.c
@@ -1320,12 +1320,11 @@ static zend_result php_zstd_output_handler_context_start(php_zstd_context *ctx)
     }
 
     zend_string *dict = php_zstd_output_handler_load_dict(ctx);
-
-    if (php_zstd_context_create_compress(ctx, level, dict) != SUCCESS) {
+    if (!PHP_ZSTD_G(compression_coding)) {
         return FAILURE;
     }
 
-    return SUCCESS;
+    return php_zstd_context_create_compress(ctx, level, dict);
 }
 
 static void php_zstd_output_handler_context_dtor(void *opaq)

Original file line number	Diff line number	Diff line change
`@@ -1320,12 +1320,11 @@ static zend_result php_zstd_output_handler_context_start(php_zstd_context *ctx)`
`1320`	`1320`	`}`
`1321`	`1321`
`1322`	`1322`	`zend_string *dict = php_zstd_output_handler_load_dict(ctx);`
`1323`		`-`
`1324`		`- if (php_zstd_context_create_compress(ctx, level, dict) != SUCCESS) {`
	`1323`	`+ if (!PHP_ZSTD_G(compression_coding)) {`
`1325`	`1324`	`return FAILURE;`
`1326`	`1325`	`}`
`1327`	`1326`
`1328`		`- return SUCCESS;`
	`1327`	`+ return php_zstd_context_create_compress(ctx, level, dict);`
`1329`	`1328`	`}`
`1330`	`1329`
`1331`	`1330`	`static void php_zstd_output_handler_context_dtor(void *opaq)`