chore(ci): update windows script

Author: kjdev

.github/workflows/build.ps1

@@ -7,7 +7,7 @@ Add-Content $task 'call phpize 2>&1'
 Add-Content $task "call configure --with-php-build=C:\php\deps --enable-$env:PHP_EXT --enable-debug-pack 2>&1"
 Add-Content $task 'nmake /nologo 2>&1'
 Add-Content $task 'exit %errorlevel%'
-& "C:\php\php-sdk-$env:BIN_SDK_VER\phpsdk-$env:VC-$env:ARCH.bat" -t $task
+& "C:\php\php-sdk-$env:BIN_SDK_VER\phpsdk-$env:VS-$env:ARCH.bat" -t $task
 if (-not $?) {
     throw "building failed with errorlevel $LastExitCode"
 }

.github/workflows/install.ps1

@@ -7,8 +7,8 @@ if (-not (Test-Path 'C:\php')) {
 # PHP SDK
 $bname = "php-sdk-$env:BIN_SDK_VER.zip"
 if (-not (Test-Path C:\php\$bname)) {
-    echo "Download: https://github.com/microsoft/php-sdk-binary-tools/archive/$bname"
-    Invoke-WebRequest "https://github.com/microsoft/php-sdk-binary-tools/archive/$bname" -OutFile "C:\php\$bname"
+    echo "Download: https://github.com/php/php-sdk-binary-tools/archive/$bname"
+    Invoke-WebRequest "https://github.com/php/php-sdk-binary-tools/archive/$bname" -OutFile "C:\php\$bname"
 }
 $dname0 = "php-sdk-binary-tools-php-sdk-$env:BIN_SDK_VER"
 $dname1 = "php-sdk-$env:BIN_SDK_VER"
@@ -32,7 +32,7 @@ $ts_part = ''
 if ('nts' -eq $env:TS) {
     $ts_part = '-nts'
 }
-$bname = "php-devel-pack-$php_version$ts_part-Win32-$env:VC-$env:ARCH.zip"
+$bname = "php-devel-pack-$php_version$ts_part-Win32-$env:VS-$env:ARCH.zip"
 if (-not (Test-Path "C:\php\$bname")) {
     try {
         echo "Download: https://windows.php.net/downloads/releases/$bname"
@@ -42,20 +42,20 @@ if (-not (Test-Path "C:\php\$bname")) {
         Invoke-WebRequest "https://windows.php.net/downloads/releases/archives/$bname" -OutFile "C:\php\$bname"
     }
 }
-$dname = "php-$php_version-devel-$env:VC-$env:ARCH"
+$dname = "php-$php_version-devel-$env:VS-$env:ARCH"
 if (-not (Test-Path "C:\php\devel")) {
     Expand-Archive "C:\php\$bname" 'C:\php'
     if (-not (Test-Path "C:\php\$dname")) {
         $php_normalize_version = $php_version.Split("-")[0]
-        $dname = "php-$php_normalize_version-devel-$env:VC-$env:ARCH"
+        $dname = "php-$php_normalize_version-devel-$env:VS-$env:ARCH"
     }
     if (-not (Test-Path "C:\php\devel")) {
         Move-Item "C:\php\$dname" "C:\php\devel"
     }
 }
 
 # PHP binary: "C:\php\bin"
-$bname = "php-$php_version$ts_part-Win32-$env:VC-$env:ARCH.zip"
+$bname = "php-$php_version$ts_part-Win32-$env:VS-$env:ARCH.zip"
 if (-not (Test-Path "C:\php\$bname")) {
     try {
         echo "Download: https://windows.php.net/downloads/releases/$bname"
@@ -71,7 +71,7 @@ if (-not (Test-Path "C:\php\bin")) {
 
 # library dependency: "C:\php\deps"
 if ("$env:DEP" -ne "") {
-    $bname = "$env:DEP-$env:VC-$env:ARCH.zip"
+    $bname = "$env:DEP-$env:VS-$env:ARCH.zip"
     if (-not (Test-Path "C:\php\$bname")) {
         echo "Download: https://windows.php.net/downloads/pecl/deps/$bname"
         Invoke-WebRequest "https://windows.php.net/downloads/pecl/deps/$bname" -OutFile "C:\php\$bname"
@@ -88,7 +88,7 @@ if (('' -ne $env:PECL_APCU) -and ('8.2' -ne $env:PHP_VER) -and ('8.3' -ne $env:P
         $ts_part = 'nts'
     }
 
-    $bname = "php_apcu-$apcu_version-$env:PHP_VER-$ts_part-$env:VC-$env:ARCH.zip"
+    $bname = "php_apcu-$apcu_version-$env:PHP_VER-$ts_part-$env:VS-$env:ARCH.zip"
 
     echo "Download: https://windows.php.net/downloads/pecl/releases/apcu/$apcu_version/$bname"
     Invoke-WebRequest "https://windows.php.net/downloads/pecl/releases/apcu/$apcu_version/$bname" -OutFile "C:\php\$bname"

.github/workflows/windows.yaml

@@ -4,7 +4,7 @@ on: [push]
 
 env:
   PHP_EXT: zstd
-  BIN_SDK_VER: 2.2.0
+  BIN_SDK_VER: 2.3.0
 
 jobs:
   ci:
@@ -21,7 +21,7 @@ jobs:
         ts:
           - 'nts'
           - 'ts'
-        vc:
+        vs:
           - vs16
           - vs17
         library:
@@ -32,20 +32,23 @@ jobs:
           - 'apcu'
         exclude:
           - php: '8.4'
-            vc: vs16
+            vs: vs16
+          - php: '8.4'
+            vs: vs17
+            apcu: 'apcu' # Doesn't exist
           - php: '8.3'
-            vc: vs17
+            vs: vs17
           - php: '8.2'
-            vc: vs17
+            vs: vs17
           - php: '8.1'
-            vc: vs17
+            vs: vs17
 
-    runs-on: windows-2019
+    runs-on: ${{ matrix.vs == 'vs17' && 'windows-2022' || 'windows-2019' }}
 
     env:
       PHP_VER: ${{ matrix.php }}
       PECL_APCU: ${{ matrix.apcu }}
-      VC: ${{ matrix.vc }}
+      VS: ${{ matrix.vs }}
       ARCH: ${{ matrix.arch }}
       TS: ${{ matrix.ts }}
 
@@ -62,7 +65,7 @@ jobs:
         run: .\.github\workflows\vcpkg.ps1
         env:
           VCPKG_LIBRARY: zstd
-        if: ${{ matrix.library && matrix.vc == 'vs16' }}
+        if: ${{ matrix.library }}
 
       - name: Install build command
         run: .\.github\workflows\install.ps1
@@ -79,7 +82,7 @@ jobs:
       - name: Store artifact DLL
         uses: actions/upload-artifact@v4
         with:
-          name: php_${{ env.PHP_EXT }}-${{ matrix.php }}-${{ matrix.ts }}-${{ matrix.vc }}-${{ matrix.arch }}
+          name: php_${{ env.PHP_EXT }}-${{ matrix.php }}-${{ matrix.ts }}-${{ matrix.vs }}-${{ matrix.arch }}
           path: .\php_${{ env.PHP_EXT }}.dll
           overwrite: true
         if: ${{ ! matrix.library && matrix.apcu == '' }}