refactor: zstd_uncompress_init() using php_zstd_context_create_decompress()

kjdev · kjdev · commit a7d5961bd92f · 2025-07-18T11:23:54.000+09:00
diff --git a/zstd.c b/zstd.c
@@ -683,19 +683,10 @@ ZEND_FUNCTION(zstd_uncompress_init)
 {
     PHP_ZSTD_CONTEXT_OBJ_INIT_OF_CLASS(php_zstd_uncompress_context_ce);
 
-    ctx->dctx = ZSTD_createDCtx();
-    if (ctx->dctx == NULL) {
+    if (php_zstd_context_create_decompress(ctx, NULL) != SUCCESS) {
         zval_ptr_dtor(return_value);
-        ZSTD_WARNING("failed to create uncompress context");
         RETURN_FALSE;
     }
-    ctx->cdict = NULL;
-
-    ZSTD_DCtx_reset(ctx->dctx, ZSTD_reset_session_only);
-
-    ctx->output.size = ZSTD_DStreamOutSize();
-    ctx->output.dst  = emalloc(ctx->output.size);
-    ctx->output.pos  = 0;
 }
 
 ZEND_FUNCTION(zstd_uncompress_add)

Original file line number	Diff line number	Diff line change
`@@ -683,19 +683,10 @@ ZEND_FUNCTION(zstd_uncompress_init)`
`683`	`683`	`{`
`684`	`684`	`PHP_ZSTD_CONTEXT_OBJ_INIT_OF_CLASS(php_zstd_uncompress_context_ce);`
`685`	`685`
`686`		`- ctx->dctx = ZSTD_createDCtx();`
`687`		`- if (ctx->dctx == NULL) {`
	`686`	`+ if (php_zstd_context_create_decompress(ctx, NULL) != SUCCESS) {`
`688`	`687`	`zval_ptr_dtor(return_value);`
`689`		`- ZSTD_WARNING("failed to create uncompress context");`
`690`	`688`	`RETURN_FALSE;`
`691`	`689`	`}`
`692`		`- ctx->cdict = NULL;`
`693`		`-`
`694`		`- ZSTD_DCtx_reset(ctx->dctx, ZSTD_reset_session_only);`
`695`		`-`
`696`		`- ctx->output.size = ZSTD_DStreamOutSize();`
`697`		`- ctx->output.dst = emalloc(ctx->output.size);`
`698`		`- ctx->output.pos = 0;`
`699`	`690`	`}`
`700`	`691`
`701`	`692`	`ZEND_FUNCTION(zstd_uncompress_add)`