Skip to content

Fixes #35 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dshorthouse wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes #35 #36

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
450f335
Fixes #35
dshorthouse Mar 9, 2025
3821896
Update entity.rb
dshorthouse Mar 9, 2025
80de2be
Return empty string in title method when no labels
dshorthouse May 12, 2026
766d7bb
Refactor title method to use explicit if statements
dshorthouse May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/wikidata/entity.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,16 @@ def id
end

def title
return labels['en'].value if labels && labels['en']
return sitelinks['en'].value if sitelinks && sitelinks['en']

title
if labels && labels.key?('mul')
return labels['mul'].value
end
if labels && labels.key?('en')
return labels['en'].value
end
if sitelinks && sitelinks.key?('en')
return sitelinks['en'].value
end
""
end

def url
Expand Down