fixes potential issue with enumerable changing if an entity is changed while executing event handlers

Kaleb Luhman · Kaleb Luhman · commit 2dcd2a0f9404 · 2020-06-23T15:32:15.000-05:00
diff --git a/src/EntityFrameworkCore.Extensions.Events/DbContextExtensions.cs b/src/EntityFrameworkCore.Extensions.Events/DbContextExtensions.cs
@@ -50,7 +50,7 @@ public static async Task<int> SaveChangesWithEventsAsync(this DbContext context,
         private static List<KeyValuePair<EntityState, EntityEntry>> HandlePreSaveEvents(this DbContext context, ICollection<IEventHandler> eventHandlers)
         {
             var entries = new List<KeyValuePair<EntityState, EntityEntry>>();
-            foreach (var entry in context.ChangeTracker.Entries())
+            foreach (var entry in context.ChangeTracker.Entries().ToList())
             {
                 foreach (var eventHandler in eventHandlers)
                 {

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public static async Task<int> SaveChangesWithEventsAsync(this DbContext context,`
`50`	`50`	`private static List<KeyValuePair<EntityState, EntityEntry>> HandlePreSaveEvents(this DbContext context, ICollection<IEventHandler> eventHandlers)`
`51`	`51`	`{`
`52`	`52`	`var entries = new List<KeyValuePair<EntityState, EntityEntry>>();`
`53`		`- foreach (var entry in context.ChangeTracker.Entries())`
	`53`	`+ foreach (var entry in context.ChangeTracker.Entries().ToList())`
`54`	`54`	`{`
`55`	`55`	`foreach (var eventHandler in eventHandlers)`
`56`	`56`	`{`