Skip to content

Commit 39dd64a

Browse files
committed
fix(cuda): drop temporary fast_fp16_available GCN4 diagnostic
719476c bundled a legitimate wave64 shuffle-width fix with an unrelated, self-labeled temporary diagnostic that force-disabled the fast fp16 path on GCN4/Polaris to test an accumulated-precision-margin theory. Flagged by the SP2+SP2.5 final whole-branch review as leaked WIP with no place in the merge. Revert fast_fp16_available to its pre-diagnostic behavior; the shuffle-width fix itself is untouched.
1 parent 1de2e8d commit 39dd64a

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

ggml/src/ggml-cuda/common.cuh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -302,9 +302,7 @@ static bool fp16_available(const int cc) {
302302
}
303303

304304
static bool fast_fp16_available(const int cc) {
305-
// DIAG(temp): gfx803/Polaris (GCN4) fp16 ALU is not truly full-rate/clean; force the
306-
// fp32-accumulation kernel paths there to test the accumulated-precision-margin theory.
307-
return (GGML_CUDA_CC_IS_AMD(cc) && !(GGML_CUDA_CC_IS_GCN(cc) && cc <= GGML_CUDA_CC_GCN4)) ||
305+
return GGML_CUDA_CC_IS_AMD(cc) ||
308306
(GGML_CUDA_CC_IS_NVIDIA(cc) && fp16_available(cc) && ggml_cuda_highest_compiled_arch(cc) != 610) ||
309307
(GGML_CUDA_CC_IS_MTHREADS(cc) && fp16_available(cc));
310308
}

0 commit comments

Comments
 (0)