Skip to content

Commit 5524a59

Browse files
kmbandyclaude
andcommitted
docs(memory-tier): correct stale Phase-2a comments on paged_blocks
paged_blocks rollout is complete (2b/2c/2d landed, legacy removed in MAD-127, effective default-on with --kv-tiered per MAD-134); default TieredConfig is 25/25/50 with the warm tier in mlock'd host RAM. Comment-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 100f1fd commit 5524a59

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

src/llama-memory.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ struct llama_memory_params {
4141
const char * kv_tier_semantic_index;
4242
float kv_tier_semantic_threshold;
4343
int32_t kv_tier_semantic_topk;
44-
bool kv_tier_paged_blocks; // Phase 2a opt-in
44+
bool kv_tier_paged_blocks; // select llama_kv_cache_paged; effective default-on with --kv-tiered (MAD-134)
4545
int32_t kv_tier_paged_block_size; // tokens/block (0 => default 16)
4646
bool kv_tier_cold_resume; // MAD-130: skip O_TRUNC on cold-tier files; load index sidecar
4747
const char * kv_tier_instance_id; // MAD-131: per-instance ID for cold subdir + lockfile (nullptr => pid)

src/memory-tier/mt-config.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -89,17 +89,17 @@ struct TieredConfig {
8989
float semantic_threshold = 0.65f;
9090
int semantic_top_k = 5;
9191

92-
// Paged-blocks refactor (PHASE 2a, opt-in, off by default).
92+
// Paged-blocks KV cache (vLLM-style block-indexed): selects the
93+
// llama_kv_cache_paged path. The phased rollout is COMPLETE — Phase 2b/2c/2d
94+
// landed, the legacy position-keyed tiered paths were removed in MAD-127, and
95+
// MAD-134 made this the EFFECTIVE default whenever --kv-tiered is set
96+
// (auto-enabled in common_context_params_to_llama unless the operator passes
97+
// --no-kv-tier-paged-blocks; the `= false` below is only the raw struct
98+
// default, before that auto-enable step). Validated end-to-end on hybrid
99+
// models (Qwen3.x); non-hybrid + ctx > 16k may hit kernel LDS limits.
93100
//
94-
// When true, llama_memory_tiered allocates a mt::BlockPool +
95-
// mt::BlockTable alongside the existing position-keyed bookkeeping.
96-
// Phase 2a only INSTANTIATES the new structures and logs init —
97-
// no live wiring yet. Phase 2b will start using BlockTable on the
98-
// write side; Phase 2c on the read side; Phase 2d makes paged
99-
// the default and removes the position-keyed paths.
100-
//
101-
// block_size is fixed at 16 tokens for now (matches vLLM default).
102-
// Configurable in a later phase if benchmarks show otherwise.
101+
// block_size is fixed at 16 tokens (matches vLLM default); configurable in a
102+
// later phase if benchmarks show otherwise.
103103
bool paged_blocks = false;
104104
uint32_t paged_block_size = 16;
105105
};

0 commit comments

Comments
 (0)