Update WorkerPool.yaml to prevent persistent diff on the scaling_mode field#2
Closed
kminsu-google wants to merge 3 commits into
Closed
Update WorkerPool.yaml to prevent persistent diff on the scaling_mode field#2kminsu-google wants to merge 3 commits into
kminsu-google wants to merge 3 commits into
Conversation
… field The `google_cloud_run_v2_worker_pool` resource would show a perpetual diff on the `scaling.scaling_mode` field. When the `scaling` block was configured (e.g., with `manual_instance_count`) but `scaling_mode` was omitted, Terraform would try to remove the `scaling_mode` attribute on subsequent plans. This occurred because the Cloud Run API defaults `scaling_mode` to "MANUAL" if not specified, but the Terraform resource schema did not reflect this default. This commit updates the `scaling.scaling_mode` field in the magic-modules YAML definition to include `default_value: 'MANUAL'` and ensures it is marked as `computed: true`. This aligns Terraform's behavior with the API, resolving the persistent diff.
For magic module context this should be `optional` which later will be translated into `computed` in Terraform.
Owner
Author
|
Need further clarification. Will come back to this with fresh PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.