Skip to content

Commit 9255180

Browse files
authored
editor: EditorTemplate request carries chart values (#655)
Change EditorTemplateRequest to carry the editor chart Values (fetched by the caller) instead of a ChartRef. getChart can exceed the aggregated apiserver request budget, so kube-ui-server only does the fast in-cluster reconstruction from these values; the caller pulls the chart. Signed-off-by: Tamal Saha <tamal@appscode.com>
1 parent 8312d45 commit 9255180

3 files changed

Lines changed: 13 additions & 12 deletions

File tree

apis/editor/v1alpha1/editortemplate_types.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,12 @@ type EditorTemplate struct {
5252

5353
type EditorTemplateRequest struct {
5454
releasesapi.ModelMetadata `json:",inline"`
55-
// ChartRef optionally selects the chart source. When unset, the resource
56-
// editor chart resolved from the metadata resource is used.
55+
// Values is the editor chart's values, fetched by the caller. The chart is
56+
// pulled (getChart) by the caller because it can take longer than the
57+
// aggregated apiserver request budget; kube-ui-server only does the fast
58+
// in-cluster reconstruction from these values.
5759
// +optional
58-
ChartRef *releasesapi.ChartSourceFlatRef `json:"chartRef,omitempty"`
60+
Values *runtime.RawExtension `json:"values,omitempty"`
5961
}
6062

6163
type EditorTemplateResponse struct {

apis/editor/v1alpha1/openapi_generated.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/editor/v1alpha1/zz_generated.deepcopy.go

Lines changed: 4 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)