Modernize golangci-lint config and switch to gofumpt

- Enable bodyclose and prealloc linters
- Move exclude-files/exclude-dirs to linters.exclusions.paths (golangci-lint
  v2 location) and fix over-escaped regex generated.*\\.go -> generated.*\.go
- Switch formatter from gofmt to gofumpt
- Update hack/fmt.sh to run `golangci-lint fmt` so `make fmt` stays consistent
  with the linter config
- Apply resulting gofumpt formatting and use fmt.Fprintf over
  Sprintf+WriteString in tableconvertor

Signed-off-by: Tamal Saha <tamal@appscode.com>

Author: tamalsaha

.golangci.yml

@@ -2,27 +2,22 @@ version: "2"
 linters:
   default: standard
   enable:
+    - bodyclose
+    - prealloc
     - unparam
+  exclusions:
+    paths:
+      - generated.*\.go
+      - client
+      - vendor
 
 formatters:
   enable:
-    - gofmt
+    - gofumpt
     - goimports
-  settings:
-    gofmt:
-      rewrite-rules:
-        - pattern: 'interface{}'
-          replacement: 'any'
 
 issues:
   max-same-issues: 100
 
-  exclude-files:
-    - generated.*\\.go
-
-  exclude-dirs:
-    - client
-    - vendor
-
 run:
   timeout: 10m

apis/editor/v1alpha1/register.go

@@ -48,11 +48,13 @@ func Resource(resource string) schema.GroupResource {
 
 // Adds the list of known types to api.Scheme.
 func addKnownTypes(scheme *runtime.Scheme) error {
-	scheme.AddKnownTypes(SchemeGroupVersion,
+	scheme.AddKnownTypes(
+		SchemeGroupVersion,
 		&EditorModel{},
 	)
 
-	scheme.AddKnownTypes(SchemeGroupVersion,
+	scheme.AddKnownTypes(
+		SchemeGroupVersion,
 		&metav1.Status{},
 	)
 	metav1.AddToGroupVersion(scheme, SchemeGroupVersion)

apis/management/v1alpha1/register.go

@@ -48,12 +48,14 @@ func Resource(resource string) schema.GroupResource {
 
 // Adds the list of known types to api.Scheme.
 func addKnownTypes(scheme *runtime.Scheme) error {
-	scheme.AddKnownTypes(SchemeGroupVersion,
+	scheme.AddKnownTypes(
+		SchemeGroupVersion,
 		&ProjectQuota{},
 		&ProjectQuotaList{},
 	)
 
-	scheme.AddKnownTypes(SchemeGroupVersion,
+	scheme.AddKnownTypes(
+		SchemeGroupVersion,
 		&metav1.Status{},
 	)
 	metav1.AddToGroupVersion(scheme, SchemeGroupVersion)

apis/meta/v1alpha1/register.go

@@ -48,7 +48,8 @@ func Resource(resource string) schema.GroupResource {
 
 // Adds the list of known types to api.Scheme.
 func addKnownTypes(scheme *runtime.Scheme) error {
-	scheme.AddKnownTypes(SchemeGroupVersion,
+	scheme.AddKnownTypes(
+		SchemeGroupVersion,
 		&ChartPresetQuery{},
 		&ClusterProfile{},
 		&ClusterProfileList{},
@@ -82,7 +83,8 @@ func addKnownTypes(scheme *runtime.Scheme) error {
 		&RenderDashboard{},
 	)
 
-	scheme.AddKnownTypes(SchemeGroupVersion,
+	scheme.AddKnownTypes(
+		SchemeGroupVersion,
 		&metav1.Status{},
 	)
 	metav1.AddToGroupVersion(scheme, SchemeGroupVersion)

apis/node/v1alpha1/register.go

@@ -48,12 +48,14 @@ func Resource(resource string) schema.GroupResource {
 
 // Adds the list of known types to api.Scheme.
 func addKnownTypes(scheme *runtime.Scheme) error {
-	scheme.AddKnownTypes(SchemeGroupVersion,
+	scheme.AddKnownTypes(
+		SchemeGroupVersion,
 		&NodeTopology{},
 		&NodeTopologyList{},
 	)
 
-	scheme.AddKnownTypes(SchemeGroupVersion,
+	scheme.AddKnownTypes(
+		SchemeGroupVersion,
 		&metav1.Status{},
 	)
 	metav1.AddToGroupVersion(scheme, SchemeGroupVersion)

apis/ui/v1alpha1/register.go

@@ -48,7 +48,8 @@ func Resource(resource string) schema.GroupResource {
 
 // Adds the list of known types to api.Scheme.
 func addKnownTypes(scheme *runtime.Scheme) error {
-	scheme.AddKnownTypes(SchemeGroupVersion,
+	scheme.AddKnownTypes(
+		SchemeGroupVersion,
 		&ClusterProfile{},
 		&ClusterProfileList{},
 		&Feature{},
@@ -63,7 +64,8 @@ func addKnownTypes(scheme *runtime.Scheme) error {
 		&ResourceOutlineFilterList{},
 	)
 
-	scheme.AddKnownTypes(SchemeGroupVersion,
+	scheme.AddKnownTypes(
+		SchemeGroupVersion,
 		&metav1.Status{},
 	)
 	metav1.AddToGroupVersion(scheme, SchemeGroupVersion)

hack/fmt.sh

@@ -34,8 +34,8 @@ if [ -n "$TARGETS" ]; then
     $cmd
     echo
 
-    echo "Running gofmt:"
-    cmd="gofmt -s -w ${TARGETS}"
+    echo "Running golangci-lint fmt:"
+    cmd="golangci-lint fmt"
     echo "$cmd"
     $cmd
     echo

pkg/tableconvertor/util.go

@@ -320,16 +320,16 @@ func describeVolume(volume core.Volume) string {
 			sources.WriteString("{")
 			if source.Secret != nil {
 				sources.WriteString("\"Type\": \"Secret\",")
-				sources.WriteString(fmt.Sprintf("\"SecretName\": %q", source.Secret.Name))
+				fmt.Fprintf(&sources, "\"SecretName\": %q", source.Secret.Name)
 			} else if source.DownwardAPI != nil {
 				sources.WriteString("\"Type\": \"DownwardAPI\",")
 				sources.WriteString("\"DownwardAPI\": \"true\"")
 			} else if source.ConfigMap != nil {
 				sources.WriteString("\"Type\": \"ConfigMap\",")
-				sources.WriteString(fmt.Sprintf("\"ConfigMapName\": %q", source.ConfigMap.Name))
+				fmt.Fprintf(&sources, "\"ConfigMapName\": %q", source.ConfigMap.Name)
 			} else if source.ServiceAccountToken != nil {
 				sources.WriteString("\"Type\": \"ServiceAccountToken\",")
-				sources.WriteString(fmt.Sprintf("\"TokenExpirationSeconds\": \"%v\"", source.ServiceAccountToken.ExpirationSeconds))
+				fmt.Fprintf(&sources, "\"TokenExpirationSeconds\": \"%v\"", source.ServiceAccountToken.ExpirationSeconds)
 			}
 			sources.WriteString("}")
 			if i < len(projected.Sources)-1 {