Skip to content

Commit c45c4f7

Browse files
committed
Fix popup param type's name to clearly
1 parent 85fa45e commit c45c4f7

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import DaumPostcodeEmbed, { DaumPostcodeEmbedProps, DaumPostcodeProps } from './DaumPostcodeEmbed';
2-
import useDaumPostcodePopup, { PopupOptions } from './useDaumPostcodePopup';
2+
import useDaumPostcodePopup, { DaumPostcodePopupParams } from './useDaumPostcodePopup';
33
import loadPostcode, { Address, Search, State } from './loadPostcode';
44

5-
export type { DaumPostcodeEmbedProps, DaumPostcodeProps, PopupOptions, Address, Search, State };
5+
export type { DaumPostcodeEmbedProps, DaumPostcodeProps, DaumPostcodePopupParams, Address, Search, State };
66
export { loadPostcode, DaumPostcodeEmbed, useDaumPostcodePopup };
77
export default DaumPostcodeEmbed;

src/useDaumPostcodePopup.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { useCallback, useEffect } from 'react';
22

33
import loadPostcode, { PostcodeOptions, OpenOptions, postcodeScriptUrl } from './loadPostcode';
44

5-
export type PopupOptions = Omit<PostcodeOptions, 'oncomplete' | 'onresize' | 'onclose' | 'onsearch'> &
5+
export type DaumPostcodePopupParams = Omit<PostcodeOptions, 'oncomplete' | 'onresize' | 'onclose' | 'onsearch'> &
66
Omit<OpenOptions, 'q'> & {
77
onComplete?: PostcodeOptions['oncomplete'];
88
onResize?: PostcodeOptions['onresize'];
@@ -18,7 +18,7 @@ function useDaumPostcodePopup(scriptUrl = postcodeScriptUrl) {
1818
}, [scriptUrl]);
1919

2020
const open = useCallback(
21-
(options?: PopupOptions) => {
21+
(options?: DaumPostcodePopupParams) => {
2222
const { defaultQuery, left, top, popupKey, popupTitle, autoClose, onComplete, onResize, onClose, onSearch, onError, ...others } = {
2323
...options,
2424
};

0 commit comments

Comments
 (0)