bump linter v2.5.0 -> v2.11.4 + fixes#494
Conversation
knative-prow
Bot
added
the
size/XS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
=======================================
Coverage 67.61% 67.61%
=======================================
Files 52 52
Lines 1408 1408
=======================================
Hits 952 952
Misses 386 386
Partials 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gauron99
force-pushed
the
push-onrkkzmyuxkm
branch
from
cecf447 to
0088110
Compare
gauron99
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
| }); err != nil { | ||
| t.Fatal(err, "\n\nExecution log: "+ | ||
| path.Join(cacheDir, "last-exec.log.jsonl")) | ||
| filepath.Join(cacheDir, "last-exec.log.jsonl")) |
There was a problem hiding this comment.
do we need a filepath.CLean here?
There was a problem hiding this comment.
its cleaned few lines up when the cacheDir is being defined
2 participants
fixes the CI for release
build/Magefile.goto run with go 1.26