Skip to content

bump linter v2.5.0 -> v2.11.4 + fixes #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Apr 28, 2026
Merged

bump linter v2.5.0 -> v2.11.4 + fixes #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/Magefile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func init() { //nolint:gochecknoinits
},
Artifacts: []config.Artifact{sender, cli},
Checks: []config.Task{checks.GolangCiLint(func(o *checks.GolangCiLintOptions) {
o.Version = "v2.5.0"
o.Version = "v2.11.4"
})},
BuildVariables: map[string]config.Resolver{
metadata.ImageBasenamePath(): imageBasenameFromEnv,
Expand Down
6 changes: 3 additions & 3 deletions test/e2e/ics_send.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"context"
"fmt"
"os"
"path"
"path/filepath"

cloudevents "github.com/cloudevents/sdk-go/v2"
cetest "github.com/cloudevents/sdk-go/v2/test"
Expand Down Expand Up @@ -67,7 +67,7 @@ func sendEvent(ev cloudevents.Event, sink Sink) feature.StepFn {
if artifacts == "" {
artifacts = os.TempDir()
}
cacheDir := path.Join(artifacts, t.Name())
cacheDir := filepath.Clean(filepath.Join(artifacts, t.Name()))
if err := os.MkdirAll(cacheDir, dirPerm); err != nil {
t.Fatal(err)
}
Expand All @@ -80,7 +80,7 @@ func sendEvent(ev cloudevents.Event, sink Sink) feature.StepFn {
Err: fmt.Sprintf("Event (ID: %s) have been sent.", ev.ID()),
}); err != nil {
t.Fatal(err, "\n\nExecution log: "+
path.Join(cacheDir, "last-exec.log.jsonl"))
filepath.Join(cacheDir, "last-exec.log.jsonl"))
Copy link
Copy Markdown
Contributor

@dprotaso dprotaso Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a filepath.CLean here?

Copy link
Copy Markdown
Contributor Author

@gauron99 gauron99 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its cleaned few lines up when the cacheDir is being defined

}
assert.NotContains(t, result.Stderr(), issue228Warn)
log.Info("Succeeded")
Expand Down
Loading