Skip to content

groups: fix 'occured' -> 'occurred' in service.go and reconcile.go comments#1778

Closed
SAY-5 wants to merge 2 commits into
knative:mainfrom
SAY-5:fix-groups-occured-typo
Closed

groups: fix 'occured' -> 'occurred' in service.go and reconcile.go comments#1778
SAY-5 wants to merge 2 commits into
knative:mainfrom
SAY-5:fix-groups-occured-typo

Conversation

@SAY-5

@SAY-5 SAY-5 commented Apr 16, 2026

Copy link
Copy Markdown

Five comments across groups/service.go (lines 149, 275, 324, 380) and groups/reconcile.go (line 224) read errors that occured. Fixed to occurred. Comment-only change.

SAY-5 added 2 commits April 15, 2026 21:43
@SAY-5
groups: fix 'occured' -> 'occurred' in service.go and reconcile.go co…
bd982da 
…mments

Five comments across groups/service.go and groups/reconcile.go read 'errors that occured'. Fixed to 'occurred'. Comment-only change.

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
@SAY-5
fix same typo in reconcile.go
91265f8 
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
@linux-foundation-easycla

linux-foundation-easycla Bot commented Apr 16, 2026

Copy link
Copy Markdown

CLA Not Signed

@knative-prow

knative-prow Bot commented Apr 16, 2026

Copy link
Copy Markdown

Welcome @SAY-5! It looks like this is your first PR to knative/community 🎉

@knative-prow knative-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 16, 2026
@knative-prow

knative-prow Bot commented Apr 16, 2026

Copy link
Copy Markdown

Hi @SAY-5. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2026
@dprotaso

dprotaso commented Apr 20, 2026

Copy link
Copy Markdown
Member

you'll need to sign the CLA to contribute

/lgtm
/approve

when it's done I think you check with the command /easycla on this PR

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026
@knative-prow

knative-prow Bot commented Apr 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, SAY-5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2026
@dprotaso

dprotaso commented Apr 21, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2026
@SAY-5

SAY-5 commented Apr 28, 2026

Copy link
Copy Markdown
Author

Closing — typo-only PR. Multiple maintainers across the OSS ecosystem have flagged my recent typo-sweep PRs as AI-generated spam (notably hashicorp/nomad#27855, hashicorp/hcl#794, argo-cd reviewers). I should have caught this pattern sooner. Apologies for the noise.

@SAY-5 SAY-5 closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson
@upodroid upodroid Awaiting requested review from upodroid

Assignees

@dprotaso dprotaso

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SAY-5 @dprotaso