Skip to content

hack: replace fragile awk pipeline with 'go env GOARCH' in install.sh#9000

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
Ankitsinghsisodya:fix/go-env-goarch
Apr 21, 2026
Merged

hack: replace fragile awk pipeline with 'go env GOARCH' in install.sh#9000
knative-prow[bot] merged 1 commit intoknative:mainfrom
Ankitsinghsisodya:fix/go-env-goarch

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

Fixes #8999

Summary

  • Replace go env | grep GOARCH | awk -F\'' '{print $2}' with $(go env GOARCH) in hack/install.sh

go env GOARCH is the canonical, documented way to read a single Go environment variable.

The previous 'go env | grep GOARCH | awk -F\'' pipeline is fragile:
it depends on the specific output format of 'go env' which can vary.
'go env GOARCH' is the canonical, documented way to read a single
Go environment variable and is simpler and more reliable.
Copilot AI review requested due to automatic review settings April 1, 2026 10:29
@knative-prow knative-prow Bot added the area/test-and-release Test infrastructure, tests or release label Apr 1, 2026
@knative-prow knative-prow Bot requested review from evankanderson and pierDipi April 1, 2026 10:29
@knative-prow knative-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 1, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the robustness of the local development install script by switching to Go’s canonical single-variable environment query for detecting the target architecture, aligning with the documented go env <VAR> usage.

Changes:

  • Replace a fragile go env | grep ... | awk ... pipeline with go env GOARCH to populate KO_ARCH.
  • Keep KO_FLAGS platform selection behavior the same while making KO_ARCH detection more stable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@creydr
Copy link
Copy Markdown
Member

creydr commented Apr 21, 2026

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2026
@creydr
Copy link
Copy Markdown
Member

creydr commented Apr 21, 2026

Thanks for the cleanup @Ankitsinghsisodya

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitsinghsisodya, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.07%. Comparing base (c6be563) to head (0ef11cb).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9000      +/-   ##
==========================================
+ Coverage   51.02%   51.07%   +0.05%     
==========================================
  Files         409      409              
  Lines       22001    21999       -2     
==========================================
+ Hits        11225    11237      +12     
+ Misses       9914     9900      -14     
  Partials      862      862              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow Bot merged commit 32bc524 into knative:main Apr 21, 2026
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hack: fragile awk pipeline used to read GOARCH in install.sh

3 participants