hack: quote REPO_ROOT_DIR inside mktemp call in verify-codegen.sh#9004
hack: quote REPO_ROOT_DIR inside mktemp call in verify-codegen.sh#9004Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Conversation
Without quotes, an unquoted variable passed to mktemp fails when the repository root path contains spaces.
knative-prow
Bot
added
the
area/test-and-release
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
Bot
added
size/XS
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a path-handling bug in hack/verify-codegen.sh by quoting ${REPO_ROOT_DIR} in the mktemp template so the script works correctly when the repository root directory contains spaces.
Changes:
- Quote
${REPO_ROOT_DIR}in themktemp -dcall used to createTMP_DIFFROOT.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- generate-yamls.sh: quote YAML_OUTPUT_DIR in rm command - release.sh: quote dirname substitution, REPO_ROOT_DIR in cp, and $@ - verify-codegen.sh: quote REPO_ROOT_DIR inside mktemp call Unquoted variable expansions and command substitutions break when paths contain whitespace. Closes knative#8990 Closes knative#8992 Closes knative#9004
#9018) * hack: fix unquoted variables in hack scripts to prevent word-splitting - generate-yamls.sh: quote YAML_OUTPUT_DIR in rm command - release.sh: quote dirname substitution, REPO_ROOT_DIR in cp, and $@ - verify-codegen.sh: quote REPO_ROOT_DIR inside mktemp call Unquoted variable expansions and command substitutions break when paths contain whitespace. Closes #8990 Closes #8992 Closes #9004 * hack: use mapfile array for safe multi-file cp in release.sh Using a quoted space-delimited string with cp treats all paths as a single argument and breaks with multiple files. Read YAML_LIST into a local array with mapfile for the cp call, while keeping ARTIFACTS_TO_PUBLISH as a space-separated string that the upstream knative/hack release.sh expects. * hack: remove unused ARTIFACTS_TO_PUBLISH variable * ci: update actions/checkout to v6 in knative-downstream workflow * Revert "ci: update actions/checkout to v6 in knative-downstream workflow" This reverts commit 28805a6.
Fixes #9003
Summary
${REPO_ROOT_DIR}in themktempcall inhack/verify-codegen.shto handle repo paths containing spaces.