Skip to content

[e2e] relax skip_permissions assertions #9014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 2 commits into from
Apr 10, 2026
Merged

[e2e] relax skip_permissions assertions #9014

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08d76e6
relax skip_permissions assertions
maschmid Apr 7, 2026
5d09681
consistency
maschmid Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 4 additions & 20 deletions test/rekt/features/apiserversource/skip_permissions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,25 +255,17 @@ func SkipPermissionsEnabledWithRBACFeature() *feature.Feature {

var obj *appsv1.Deployment
for _, deployment := range objs.Items {
if strings.HasPrefix(deployment.Name, "apiserversource-two-") {
if strings.HasPrefix(deployment.Name, "apiserversource-two-") && deployment.Status.ReadyReplicas >= 1 {
obj = &deployment
break
}
}

if obj == nil {
t.Fatal("could not found a Deployment prefixed with 'apiserversource-two-'")
t.Fatal("could not find a Deployment prefixed with 'apiserversource-two-' with at least 1 readyReplica")
return
}

if obj.Status.ReadyReplicas != 1 {
t.Fatalf("Expected 1 ready replica, got: %d", obj.Status.ReadyReplicas)
}

if obj.Status.UnavailableReplicas != 0 {
t.Fatalf("Expected 0 unavailable replica, got: %d", obj.Status.UnavailableReplicas)
}

for _, envvar := range obj.Spec.Template.Spec.Containers[0].Env {
if envvar.Name == "K_SOURCE_CONFIG" {
var config apiserver.Config
Expand Down Expand Up @@ -482,25 +474,17 @@ func SkipPermissionsDisabledWithRBACFeature() *feature.Feature {

var obj *appsv1.Deployment
for _, deployment := range objs.Items {
if strings.HasPrefix(deployment.Name, "apiserversource-four-") {
if strings.HasPrefix(deployment.Name, "apiserversource-four-") && deployment.Status.ReadyReplicas >= 1 {
obj = &deployment
break
}
}

if obj == nil {
t.Fatal("could not found a Deployment prefixed with 'apiserversource-four-'")
t.Fatal("could not find a Deployment prefixed with 'apiserversource-four-' with at least 1 readyReplica")
return
}

if obj.Status.ReadyReplicas != 1 {
t.Fatalf("Expected 1 ready replica, got: %d", obj.Status.ReadyReplicas)
}

if obj.Status.UnavailableReplicas != 0 {
t.Fatalf("Expected 0 unavailable replica, got: %d", obj.Status.UnavailableReplicas)
}

for _, envvar := range obj.Spec.Template.Spec.Containers[0].Env {
if envvar.Name == "K_SOURCE_CONFIG" {
var config apiserver.Config
Expand Down
Loading