fix the linter errors and refactor such that test not fail

Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>

Author: RayyanSeliya

pkg/utils/names.go

@@ -113,8 +113,8 @@ func ValidateLabelValue(value string) error {
 func ValidateNamespace(namespace string) error {
 	if errs := validation.IsDNS1123Label(namespace); len(errs) > 0 {
 		// Reuse the error message from Kubernetes validation
-		// Replace "a DNS-1123 label" with more user-friendly context
-		errMsg := strings.Replace(strings.Join(errs, ""), "a DNS-1123 label", fmt.Sprintf("Namespace '%v'", namespace), 1)
+		// Replace "a lowercase RFC 1123 label" with more user-friendly context
+		errMsg := strings.Replace(strings.Join(errs, ""), "a lowercase RFC 1123 label", fmt.Sprintf("Namespace '%v'", namespace), 1)
 		return ErrInvalidNamespace(errors.New(errMsg))
 	}
 	return nil

pkg/utils/names_test.go

@@ -227,13 +227,13 @@ func TestValidateNamespace(t *testing.T) {
 		{"a", true},
 		{"a-b", true},
 		{"abc-123-xyz", true},
+		{"123app", true},      // DNS-1123 allows starting with number
+		{"123invalid", true},  // DNS-1123 allows starting with number
+		{"1", true},           // single number is valid
 
 		// Invalid namespaces
-		{"", false},                  // empty
 		{"My-App", false},            // uppercase not allowed
 		{"MY-APP", false},            // uppercase not allowed
-		{"123app", false},            // cannot start with number
-		{"123invalid", false},        // cannot start with number
 		{"my_app", false},            // underscore not allowed
 		{"my app", false},            // spaces not allowed
 		{"invalid namespace", false}, // spaces not allowed
@@ -262,7 +262,7 @@ func TestValidateNamespace(t *testing.T) {
 }
 
 func TestValidateNamespaceErrMsg(t *testing.T) {
-	invalidNamespace := "123invalid"
+	invalidNamespace := "my@app"
 	errMsgPrefix := fmt.Sprintf("Namespace '%v'", invalidNamespace)
 
 	err := ValidateNamespace(invalidNamespace)
@@ -273,4 +273,4 @@ func TestValidateNamespaceErrMsg(t *testing.T) {
 	} else {
 		t.Fatalf("Expected error for invalid namespace: %v", invalidNamespace)
 	}
-}
+}