refactor: move CI workflow to pkg/ci/github

The CI workflow generation lived in cmd/ci/, tightly coupled to
the command layer via viper flag reads and direct file I/O. This
made it impossible to reuse or test the generator independently.

Move workflow generation, printing, and writing into
pkg/ci/github/ as a self-contained package. Introduce CI and
PathWriter interfaces in pkg/functions/client.go so the client
can orchestrate workflow generation without depending on the
cmd layer. The cmd/config_ci.go command now resolves flags and
delegates to client.GenerateCIWorkflow().

Also fix typos: --patform → --platform, functionl → function,
proivdes → provides, precldes → precedes, sevices → services,
suppot → support, Desribe → Describe, pipilines → pipelines,
intance → instance.

Issue #3256

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>

Author: twoGiants

cmd/build.go

@@ -501,7 +501,7 @@ func (c buildConfig) buildOptions() (oo []fn.BuildOption, err error) {
 	if c.Platform != "" {
 		parts := strings.Split(c.Platform, "/")
 		if len(parts) != 2 {
-			return oo, fmt.Errorf("the value for --patform must be in the form [OS]/[Architecture].  eg \"linux/amd64\"")
+			return oo, fmt.Errorf("the value for --platform must be in the form [OS]/[Architecture].  eg \"linux/amd64\"")
 		}
 		oo = append(oo, fn.BuildWithPlatforms([]fn.Platform{{OS: parts[0], Architecture: parts[1]}}))
 	}

cmd/ci/config.go

@@ -6,6 +6,7 @@ import (
 	"os"
 
 	"github.com/ory/viper"
+	"knative.dev/func/pkg/ci/github"
 	"knative.dev/func/pkg/keda"
 
 	"knative.dev/func/cmd/prompt"
@@ -78,6 +79,7 @@ func NewClient(cfg ClientConfig, options ...fn.Option) (*fn.Client, func()) {
 				docker.WithCredentialsProvider(c),
 				docker.WithTransport(t),
 				docker.WithVerbose(cfg.Verbose))),
+			fn.WithCI(github.NewWorkflowGenerator(cfg.Verbose)),
 		}
 	)
 

cmd/client.go

@@ -8,15 +8,14 @@ import (
 	"github.com/ory/viper"
 	"github.com/spf13/cobra"
 
-	"knative.dev/func/cmd/ci"
 	"knative.dev/func/cmd/common"
 	"knative.dev/func/pkg/config"
 	fn "knative.dev/func/pkg/functions"
 )
 
 func NewConfigCmd(
 	loaderSaver common.FunctionLoaderSaver,
-	writer ci.WorkflowWriter,
+	pathWriter fn.PathWriter,
 	currentBranch common.CurrentBranchFunc,
 	workingDir common.WorkDirFunc,
 	newClient ClientFactory,
@@ -47,8 +46,14 @@ or from the directory specified with --path.
 	cmd.AddCommand(NewConfigEnvsCmd(loaderSaver))
 	cmd.AddCommand(NewConfigVolumesCmd())
 
-	if os.Getenv(ci.ConfigCIFeatureFlag) == "true" {
-		cmd.AddCommand(NewConfigCICmd(loaderSaver, writer, currentBranch, workingDir))
+	if os.Getenv(ConfigCIFeatureFlag) == "true" {
+		cmd.AddCommand(NewConfigCICmd(
+			loaderSaver,
+			pathWriter,
+			currentBranch,
+			workingDir,
+			newClient,
+		))
 	}
 
 	return cmd