Skip to content

update Rust templates to be a more accurate echo#3099

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
lkingland:push-oyrtuknxnzoy
Oct 20, 2025
Merged

update Rust templates to be a more accurate echo#3099
knative-prow[bot] merged 1 commit intoknative:mainfrom
lkingland:push-oyrtuknxnzoy

Conversation

@lkingland
Copy link
Copy Markdown
Member

Default templates should be as accurate of an echo as possible for ease of testing/validation. This updates the Rust templates thusly

@knative-prow knative-prow Bot requested review from dsimansk and nainaz October 15, 2025 08:06
@knative-prow knative-prow Bot added approved 🤖 PR has been approved by an approver from all required OWNERS files. size/M 🤖 PR changes 30-99 lines, ignoring generated files. labels Oct 15, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.07%. Comparing base (5093bfb) to head (fc976c2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3099      +/-   ##
==========================================
+ Coverage   58.33%   59.07%   +0.73%     
==========================================
  Files         134      134              
  Lines       17364    17364              
==========================================
+ Hits        10130    10258     +128     
+ Misses       6293     6137     -156     
- Partials      941      969      +28     
Flag Coverage Δ
e2e-tests 40.25% <ø> (+1.29%) ⬆️
integration-tests 53.84% <ø> (+1.64%) ⬆️
unit-tests 46.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkingland
Copy link
Copy Markdown
Member Author

/retest-required

@gauron99 gauron99 self-assigned this Oct 16, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Cannot be merged due to conflicts with HEAD. label Oct 19, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Cannot be merged due to conflicts with HEAD. label Oct 19, 2025
Copy link
Copy Markdown
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Oct 20, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot merged commit b78c1d0 into knative:main Oct 20, 2025
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. size/M 🤖 PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants