Skip to content

cleanup: Update deprecated functions#3114

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
gauron99:push-ryvqtkywxlpw
Oct 20, 2025
Merged

cleanup: Update deprecated functions#3114
knative-prow[bot] merged 1 commit intoknative:mainfrom
gauron99:push-ryvqtkywxlpw

Conversation

@gauron99
Copy link
Copy Markdown
Contributor

No description provided.

@knative-prow knative-prow Bot requested review from dsimansk and nainaz October 18, 2025 14:03
@knative-prow knative-prow Bot added approved 🤖 PR has been approved by an approver from all required OWNERS files. size/L 🤖 PR changes 100-499 lines, ignoring generated files. labels Oct 18, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.06%. Comparing base (596a122) to head (4369fac).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/builders/buildpacks/scaffolding_injector.go 0.00% 2 Missing ⚠️
pkg/builders/s2i/builder.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3114      +/-   ##
==========================================
+ Coverage   58.32%   59.06%   +0.74%     
==========================================
  Files         134      134              
  Lines       17350    17350              
==========================================
+ Hits        10119    10248     +129     
+ Misses       6292     6135     -157     
- Partials      939      967      +28     
Flag Coverage Δ
e2e-tests 40.22% <40.00%> (+1.34%) ⬆️
integration-tests 53.87% <0.00%> (+1.64%) ⬆️
unit-tests 46.19% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines -489 to +493
return c.pimpl.ImageInspectWithRaw(arg0, arg1)
var buf bytes.Buffer
ii, err := c.pimpl.ImageInspect(arg0, arg1, client.ImageInspectWithRawResponse(&buf))
return ii, buf.Bytes(), err
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pointing this out since its the only "non-simple" change

@gauron99
Copy link
Copy Markdown
Contributor Author

Maybe we could try to make the generator for this again?

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Oct 20, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gauron99
Copy link
Copy Markdown
Contributor Author

/retest

@knative-prow knative-prow Bot merged commit 1022851 into knative:main Oct 20, 2025
46 of 47 checks passed
@gauron99 gauron99 deleted the push-ryvqtkywxlpw branch November 18, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. size/L 🤖 PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants