feat(cmd): handle ErrEnvNotExist with typed error checking#3126
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
Bot
added
needs-ok-to-test
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3126 +/- ##
==========================================
+ Coverage 58.32% 60.18% +1.85%
==========================================
Files 134 134
Lines 17369 13506 -3863
==========================================
- Hits 10131 8128 -2003
+ Misses 6300 4408 -1892
- Partials 938 970 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @gauron99 , It is ready for review. |
|
Hey @gauron99 , All tests passed in this pr . |
|
/ok-to-test |
knative-prow
Bot
added
ok-to-test
| type ErrEnvNotExist struct { | ||
| Name string | ||
| } | ||
|
|
||
| func (e ErrEnvNotExist) Error() string { | ||
| return fmt.Sprintf("environment variable %q does not exist", e.Name) | ||
| } |
There was a problem hiding this comment.
can we put this into pkg/functions/errors.go please to keep consistent with the place for error definitions.
Otherwise looks good to me
There was a problem hiding this comment.
Hey @gauron99 , Thanks for this suggestion ! Now Is it good to go ?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, intojhanurag The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
2 participants
Changes
ErrEnvNotExistto clearly indicate missing environment variables.errors.Asto assert that the correct typed error is returned.Namefield inErrEnvNotExistmatches the expected missing environment variable.