Add namespace validation to catch invalid names before build/deploy by RayyanSeliya · Pull Request #3133 · knative/func

RayyanSeliya · 2025-10-22T19:46:28Z

Changes

🎁 Add early namespace validation with user-friendly error messages
🐛 Prevent wasted build time when using invalid namespace names
🧹 Add comprehensive unit tests for namespace validation

Adds DNS-1123 validation for namespace names before build/deploy operations. Invalid namespace names now fail immediately with clear error messages instead of proceeding through lengthy builds.

Implementation:

Add ValidateNamespace() function using Kubernetes DNS-1123 validation (pkg/utils/names.go)
Add validation check in deployConfig.Validate() and error handling in runDeploy() (cmd/deploy.go)
Add ErrInvalidNamespace error type (pkg/functions/errors.go) with user-friendly CLI message

/kind enhancement

Fixes #3132

Release Note

Invalid namespace names are now caught immediately with helpful error messages, preventing wasted build time

knative-prow · 2025-10-22T19:46:38Z

Hi @RayyanSeliya. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-10-22T20:02:36Z

Codecov Report

❌ Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.10%. Comparing base (b785e68) to head (a8a0ec9).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/deploy.go	15.38%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
+ Coverage   62.37%   63.10%   +0.73%     
==========================================
  Files         150      150              
  Lines       13501    13519      +18     
==========================================
+ Hits         8421     8531     +110     
+ Misses       4103     3981     -122     
- Partials      977     1007      +30

Flag	Coverage Δ
e2e-tests	`42.25% <16.66%> (+1.42%)`	⬆️
integration-tests	`57.51% <11.11%> (+1.59%)`	⬆️
unit-tests	`49.44% <38.88%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

RayyanSeliya · 2025-10-24T07:33:54Z

Hey @gauron99 can u have alook when u have some moments am I doing right ?

gauron99 · 2025-11-04T14:55:43Z

same here as with my other comment on different PR. I think we could put the utils stuff inside cmd/deploy because its only used there.

WDYT @lkingland ?

gauron99 · 2025-11-04T09:54:23Z

+// ValidateNamespace validates that the input name is a valid Kubernetes namespace name, ie. valid DNS-1035 label.
+// It must consist of lower case alphanumeric characters or '-',
+// start with an alphabetic character, and end with an alphanumeric character
+// (e.g. 'my-namespace', 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')


I would like it if there could be a link in the comment to the k8s docs so the source is easily accessible for what the limits here are.

@matejvasek @lkingland anything you can think of we are missing here for the namespace rules? or any other labels?

RayyanSeliya · 2025-11-05T09:19:17Z

Hey @gauron99 should I wait for luke and other member for opinion or should I implement as you have described ?

lkingland

/lgtm

RayyanSeliya · 2025-11-11T08:44:08Z

same here some of the test are failing @lkingland @gauron99 dont know why !

gauron99 · 2025-11-11T09:33:58Z

/override "On Cluster RT Test (ubuntu-latest, pack)" "E2E Test (ubuntu-latest, springboot)"
These fails are due to custom pack builder issue with springboot
/lgtm
/approve

knative-prow · 2025-11-11T09:34:02Z

@gauron99: Overrode contexts on behalf of gauron99: E2E Test (ubuntu-latest, springboot), On Cluster RT Test (ubuntu-latest, pack)

Details

In response to this:

/override "On Cluster RT Test (ubuntu-latest, pack)" "E2E Test (ubuntu-latest, springboot)"
These fails are due to custom pack builder issue with springboot
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>

gauron99 · 2025-11-13T08:46:21Z

/lgtm
/approve

knative-prow · 2025-11-13T08:46:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland, RayyanSeliya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [gauron99,lkingland]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow Bot added the kind/enhancement Feature additions or improvements to existing label Oct 22, 2025

knative-prow Bot requested review from dsimansk and jrangelramos October 22, 2025 19:46

knative-prow Bot added size/L 🤖 PR changes 100-499 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Oct 22, 2025

gauron99 reviewed Nov 1, 2025

View reviewed changes

Comment thread pkg/utils/names_test.go Outdated

gauron99 self-assigned this Nov 1, 2025

gauron99 requested review from jrangelramos and matejvasek and removed request for dsimansk and jrangelramos November 1, 2025 12:51

RayyanSeliya force-pushed the namespace-check branch from 3a6126d to bf14a13 Compare November 2, 2025 10:52

RayyanSeliya requested a review from gauron99 November 2, 2025 18:31

gauron99 reviewed Nov 4, 2025

View reviewed changes

lkingland approved these changes Nov 11, 2025

View reviewed changes

knative-prow Bot assigned lkingland Nov 11, 2025

knative-prow Bot added lgtm 🤖 PR is ready to be merged. approved 🤖 PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2025

lkingland added ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test 🤖 Needs an org member to approve testing labels Nov 11, 2025

knative-prow-robot added the needs-rebase Cannot be merged due to conflicts with HEAD. label Nov 11, 2025

RayyanSeliya force-pushed the namespace-check branch from fc450f0 to 9cdeda1 Compare November 11, 2025 07:50

knative-prow Bot removed the lgtm 🤖 PR is ready to be merged. label Nov 11, 2025

knative-prow-robot removed the needs-rebase Cannot be merged due to conflicts with HEAD. label Nov 11, 2025

knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Nov 11, 2025

knative-prow-robot added the needs-rebase Cannot be merged due to conflicts with HEAD. label Nov 11, 2025

RayyanSeliya added 7 commits November 12, 2025 18:47

Add namespace validation to catch invalid names before build/deploy

853b610

Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>

fix the linter errors and refactor such that test not fail

781cf91

Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>

fix the goimports

682b834

Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>

refactor based on the rfc-1123 dns ruling

39ba730

Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>

use dns-1035 validation to enforce alphabetic start for namespace

b896336

Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>

fixed some inconcistencies due to merge conflicts

ead7e33

Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>

goimports after merge conflict

a8a0ec9

Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>

RayyanSeliya force-pushed the namespace-check branch from 9cdeda1 to a8a0ec9 Compare November 12, 2025 13:20

knative-prow Bot removed the lgtm 🤖 PR is ready to be merged. label Nov 12, 2025

knative-prow-robot removed the needs-rebase Cannot be merged due to conflicts with HEAD. label Nov 12, 2025

knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Nov 13, 2025

knative-prow Bot merged commit af45a47 into knative:main Nov 13, 2025
46 of 47 checks passed

RayyanSeliya mentioned this pull request Dec 21, 2025

fix(func): reject invalid function names with consecutive hyphens (DNS-1035) #3313

Closed

Conversation

RayyanSeliya commented Oct 22, 2025

Changes

Uh oh!

knative-prow Bot commented Oct 22, 2025

Uh oh!

codecov Bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

RayyanSeliya commented Oct 24, 2025

Uh oh!

Uh oh!

gauron99 commented Nov 4, 2025

Uh oh!

gauron99 Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

gauron99 Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

RayyanSeliya commented Nov 5, 2025

Uh oh!

lkingland left a comment

Choose a reason for hiding this comment

Uh oh!

RayyanSeliya commented Nov 11, 2025

Uh oh!

gauron99 commented Nov 11, 2025

Uh oh!

knative-prow Bot commented Nov 11, 2025

Uh oh!

gauron99 commented Nov 13, 2025

Uh oh!

knative-prow Bot commented Nov 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Oct 22, 2025 •

edited

Loading