Skip to content

Add ESLint support for Node.js templates#3134

Closed
intojhanurag wants to merge 1 commit intoknative:mainfrom
intojhanurag:feat/add-node-lint-check
Closed

Add ESLint support for Node.js templates#3134
intojhanurag wants to merge 1 commit intoknative:mainfrom
intojhanurag:feat/add-node-lint-check

Conversation

@intojhanurag
Copy link
Copy Markdown
Member

What this PR does

  • Adds ESLint to Node.js templates (http and cloudevents).
  • Adds a lint script to each template's package.json.
  • Updates the Makefile check-node target to run npm ci && npm run lint for both templates.
  • Integrates Node.js linting into make check-templates alongside Go and Rust template checks.

Notes

  • No other dependencies were upgraded.
  • Node.js engine warnings are ignored (current Node v22 is higher than the package requirement).

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: intojhanurag
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the size/XXL 🤖 PR changes 1000+ lines, ignoring generated files. label Oct 23, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Oct 23, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the needs-ok-to-test 🤖 Needs an org member to approve testing label Oct 23, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.68%. Comparing base (252a2ce) to head (80dcf7c).

❗ There is a different number of reports uploaded between BASE (252a2ce) and HEAD (80dcf7c). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (252a2ce) HEAD (80dcf7c)
1 0
unit-tests 3 0
integration-tests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3134       +/-   ##
===========================================
- Coverage   59.37%   41.68%   -17.70%     
===========================================
  Files         134      117       -17     
  Lines       13500    13050      -450     
===========================================
- Hits         8016     5440     -2576     
- Misses       4540     6781     +2241     
+ Partials      944      829      -115     
Flag Coverage Δ
e2e-tests 41.68% <ø> (+1.46%) ⬆️
integration-tests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@intojhanurag
Copy link
Copy Markdown
Member Author

Hey @lkingland , it is ready for review.

@knative-prow-robot knative-prow-robot added the needs-rebase Cannot be merged due to conflicts with HEAD. label Oct 27, 2025
@intojhanurag intojhanurag force-pushed the feat/add-node-lint-check branch from 574323f to 80dcf7c Compare October 27, 2025 16:12
@knative-prow-robot knative-prow-robot removed the needs-rebase Cannot be merged due to conflicts with HEAD. label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test 🤖 Needs an org member to approve testing size/XXL 🤖 PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants