Add ESLint support for Node.js templates#3134
Add ESLint support for Node.js templates#3134intojhanurag wants to merge 1 commit intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: intojhanurag The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3134 +/- ##
===========================================
- Coverage 59.37% 41.68% -17.70%
===========================================
Files 134 117 -17
Lines 13500 13050 -450
===========================================
- Hits 8016 5440 -2576
- Misses 4540 6781 +2241
+ Partials 944 829 -115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @lkingland , it is ready for review. |
574323f to
80dcf7c
Compare
What this PR does
httpandcloudevents).lintscript to each template'spackage.json.check-nodetarget to runnpm ci && npm run lintfor both templates.make check-templatesalongside Go and Rust template checks.Notes