Enable local volume mounts in func run for ConfigMaps, Secrets, EmptyDirs, and PVCs#3143
Enable local volume mounts in func run for ConfigMaps, Secrets, EmptyDirs, and PVCs#3143intojhanurag wants to merge 3 commits intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: intojhanurag The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3143 +/- ##
==========================================
+ Coverage 59.39% 59.94% +0.54%
==========================================
Files 134 133 -1
Lines 13495 13524 +29
==========================================
+ Hits 8016 8107 +91
+ Misses 4538 4443 -95
- Partials 941 974 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @lkingland , Can you review this PR. I am not sure why that 1 test is failing. |
4582248 to
ac97a6a
Compare
|
I see in the unit test |
hey @gauron99 , So what I can do for this ? |
|
I dont know, havent seen this error exactly. You can track it down and try to debug what happened. But some change you made in this code is causing that because it doesnt happen on main |
fix: #2940
Changes
pkg/docker/runner.go -> newHostConfig()to mount the following volume types:.func/run/configmaps/<name>directory.func/run/secrets/<name>directory.func/run/pvcs/<claimName>directory.functo prevent accidental access to sensitive host directories.