Add TypeScript linting to templates#3147
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3147 +/- ##
==========================================
+ Coverage 59.39% 60.16% +0.77%
==========================================
Files 134 134
Lines 13500 13500
==========================================
+ Hits 8018 8122 +104
+ Misses 4539 4407 -132
- Partials 943 971 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @gauron99 , Can u have alook when you have some moments . I rebased as you recommended but still that verify test cases is failing . |
|
/retest |
|
/ok-to-test |
|
/retest |
|
/lgtm |
|
/test |
|
@gauron99: The Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
please rebase on main latest changes, that will fix the verify |
31be0bd to
d16615a
Compare
|
Hey @gauron99 , I reabased . I don't know what is happening ? |
|
/retest |
|
Hey @gauron99 , all tests has been passed , please take a look on it if you have a moment. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, intojhanurag The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR adds ESLint checks for TypeScript templates (
httpandcloudevents)to ensure code quality. It updates the Makefile with a new target
check-typescriptand includes it incheck-templates.Changes
npm ciandnpx eslint --ext .ts .for both templatesnode_modulesandbuildartifacts after linting