Skip to content

Add TypeScript linting to templates#3147

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
intojhanurag:add-typescript-eslint-check
Nov 5, 2025
Merged

Add TypeScript linting to templates#3147
knative-prow[bot] merged 1 commit intoknative:mainfrom
intojhanurag:add-typescript-eslint-check

Conversation

@intojhanurag
Copy link
Copy Markdown
Member

Description

This PR adds ESLint checks for TypeScript templates (http and cloudevents)
to ensure code quality. It updates the Makefile with a new target
check-typescript and includes it in check-templates.

Changes

  • Runs npm ci and npx eslint --ext .ts . for both templates
  • Cleans up node_modules and build artifacts after linting

@knative-prow knative-prow Bot requested review from jrangelramos and nainaz October 25, 2025 05:01
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Oct 25, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added needs-ok-to-test 🤖 Needs an org member to approve testing size/XS 🤖 PR changes 0-9 lines, ignoring generated files. labels Oct 25, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.16%. Comparing base (b2b8009) to head (d16615a).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3147      +/-   ##
==========================================
+ Coverage   59.39%   60.16%   +0.77%     
==========================================
  Files         134      134              
  Lines       13500    13500              
==========================================
+ Hits         8018     8122     +104     
+ Misses       4539     4407     -132     
- Partials      943      971      +28     
Flag Coverage Δ
e2e-tests 41.68% <ø> (+1.46%) ⬆️
integration-tests 54.69% <ø> (+1.67%) ⬆️
unit-tests 46.73% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@intojhanurag
Copy link
Copy Markdown
Member Author

intojhanurag commented Oct 25, 2025

Hey @gauron99 , Can u have alook when you have some moments . I rebased as you recommended but still that verify test cases is failing .

@gauron99
Copy link
Copy Markdown
Contributor

/retest

@gauron99
Copy link
Copy Markdown
Contributor

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test 🤖 Needs an org member to approve testing labels Oct 30, 2025
@gauron99
Copy link
Copy Markdown
Contributor

gauron99 commented Nov 1, 2025

/retest

@gauron99
Copy link
Copy Markdown
Contributor

gauron99 commented Nov 1, 2025

/lgtm
/approve

@knative-prow knative-prow Bot added lgtm 🤖 PR is ready to be merged. approved 🤖 PR has been approved by an approver from all required OWNERS files. labels Nov 1, 2025
@gauron99
Copy link
Copy Markdown
Contributor

gauron99 commented Nov 1, 2025

/test

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Nov 1, 2025

@gauron99: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test unit-tests

Use /test all to run all jobs.

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gauron99
Copy link
Copy Markdown
Contributor

gauron99 commented Nov 1, 2025

/retest

@gauron99
Copy link
Copy Markdown
Contributor

gauron99 commented Nov 1, 2025

please rebase on main latest changes, that will fix the verify

@intojhanurag intojhanurag force-pushed the add-typescript-eslint-check branch from 31be0bd to d16615a Compare November 2, 2025 04:16
@knative-prow knative-prow Bot removed the lgtm 🤖 PR is ready to be merged. label Nov 2, 2025
@intojhanurag
Copy link
Copy Markdown
Member Author

Hey @gauron99 , I reabased . I don't know what is happening ?

@gauron99
Copy link
Copy Markdown
Contributor

gauron99 commented Nov 4, 2025

/retest

@intojhanurag
Copy link
Copy Markdown
Member Author

Hey @gauron99 , all tests has been passed , please take a look on it if you have a moment.

@gauron99
Copy link
Copy Markdown
Contributor

gauron99 commented Nov 5, 2025

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Nov 5, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, intojhanurag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot merged commit c9d4c54 into knative:main Nov 5, 2025
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants