feat: warn when func invoke type mismatches declared function type#3162
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3162 +/- ##
==========================================
+ Coverage 59.37% 60.12% +0.74%
==========================================
Files 134 134
Lines 13500 13505 +5
==========================================
+ Hits 8016 8120 +104
+ Misses 4540 4412 -128
- Partials 944 973 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @gauron99, this issue was pending for a while. Since you were assigned , I went ahead and created one to move it forward. |
|
/ok-to-test |
|
Hey @gauron99 , Can you check , why tests are failing ! If anything is on myside lmk ! |
|
/retest |
|
Hey @gauron99 , Now Is it good to go ? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, intojhanurag The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix: #3083
This PR improves the developer experience when invoking functions with mismatched types.
Previously, if a user invoked a function with
func invoke -f cloudeventswhile the function'sfunc.yamldeclaredinvoke: http, the command failed silently with a confusing error.Now, the CLI detects this mismatch and prints a clear warning before proceeding.