Skip to content

refactor(mcp): make Name, Title, Version unexported and improved comment#3171

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
intojhanurag:refactor-mcp-unexport-vars
Nov 11, 2025
Merged

refactor(mcp): make Name, Title, Version unexported and improved comment#3171
knative-prow[bot] merged 1 commit intoknative:mainfrom
intojhanurag:refactor-mcp-unexport-vars

Conversation

@intojhanurag
Copy link
Copy Markdown
Member

This PR applies a reviewer suggestion left unimplemented in a previous merge.
Refactors Name, Title, and Version constants to unexported (name, title, version) as suggested for better encapsulation and to align with Go naming conventions and also clarify command execution comment.

Follow-up to: #3155

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Nov 7, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added size/S 🤖 PR changes 10-29 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Nov 7, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.87%. Comparing base (8f447a8) to head (62a72f9).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3171      +/-   ##
==========================================
+ Coverage   62.85%   63.87%   +1.02%     
==========================================
  Files         148      150       +2     
  Lines       13202    13210       +8     
==========================================
+ Hits         8298     8438     +140     
+ Misses       3941     3783     -158     
- Partials      963      989      +26     
Flag Coverage Δ
e2e-tests 42.97% <0.00%> (+1.49%) ⬆️
integration-tests 58.30% <100.00%> (+1.73%) ⬆️
unit-tests 50.15% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@intojhanurag
Copy link
Copy Markdown
Member Author

Hey @gauron99 , Can you take a look on it , if you have a moment ?

Copy link
Copy Markdown
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Nov 11, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: intojhanurag, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
@knative-prow knative-prow Bot merged commit 2cc5f52 into knative:main Nov 11, 2025
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. needs-ok-to-test 🤖 Needs an org member to approve testing size/S 🤖 PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants