Skip to content

refactor(mcp): make Name, Title, Version unexported and improved comment #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Nov 11, 2025
Merged

refactor(mcp): make Name, Title, Version unexported and improved comment #3171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions pkg/mcp/mcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ import (
)

const (
Name = "func"
Title = "func"
Version = "0.1.0"
name = "func"
title = "func"
version = "0.1.0"
)

// NOTE: Invoking prompts in some interfaces (such as Claude Code) when all
Expand Down Expand Up @@ -77,9 +77,9 @@ func New(options ...Option) *Server {

i := mcp.NewServer(
&mcp.Implementation{
Name: Name,
Title: Title,
Version: Version},
Name: name,
Title: title,
Version: version},
&mcp.ServerOptions{
Instructions: instructions(s.readonly),
HasPrompts: true,
Expand Down Expand Up @@ -158,7 +158,7 @@ func (e defaultExecutor) Execute(ctx context.Context, subcommand string, args ..
cmdParts = append(cmdParts, args...)

cmd := exec.CommandContext(ctx, cmdParts[0], cmdParts[1:]...)
// Commands always execute in current working directory
// cmd.Dir not set - inherits process working directory which is the current working directory
return cmd.CombinedOutput()
}

Expand Down
Loading