Skip to content

Better error message for s2i build#3185

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
matejvasek:better-error-for-s2i
Nov 12, 2025
Merged

Better error message for s2i build#3185
knative-prow[bot] merged 1 commit intoknative:mainfrom
matejvasek:better-error-for-s2i

Conversation

@matejvasek
Copy link
Copy Markdown
Contributor

Changes

  • 🎁 Better error for s2i build -- show inner cause of the error.
feat: better error for s2i build -- show inner cause of the error

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
@knative-prow knative-prow Bot added the size/XS 🤖 PR changes 0-9 lines, ignoring generated files. label Nov 12, 2025
@jrangelramos
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Nov 12, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.15%. Comparing base (b785e68) to head (fe2c0c4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3185      +/-   ##
==========================================
+ Coverage   62.37%   63.15%   +0.77%     
==========================================
  Files         150      150              
  Lines       13501    13504       +3     
==========================================
+ Hits         8421     8528     +107     
+ Misses       4103     3971     -132     
- Partials      977     1005      +28     
Flag Coverage Δ
e2e-tests 42.28% <0.00%> (+1.45%) ⬆️
integration-tests 57.59% <100.00%> (+1.67%) ⬆️
unit-tests 49.47% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow Bot merged commit fb2d118 into knative:main Nov 12, 2025
39 checks passed
matejvasek added a commit to openshift-knative/kn-plugin-func that referenced this pull request Jan 15, 2026
picking knative#3185

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
matejvasek added a commit to openshift-knative/kn-plugin-func that referenced this pull request Jan 20, 2026
picking knative#3185

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
matejvasek added a commit to openshift-knative/kn-plugin-func that referenced this pull request Jan 20, 2026
picking knative#3185

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
openshift-merge-bot Bot pushed a commit to openshift-knative/kn-plugin-func that referenced this pull request Jan 20, 2026
picking knative#3185

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants