fix: compare labels and annotations in EnsureSecretExist#3191
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3191 +/- ##
==========================================
- Coverage 51.81% 51.75% -0.06%
==========================================
Files 162 162
Lines 19131 19156 +25
==========================================
+ Hits 9912 9915 +3
- Misses 8241 8264 +23
+ Partials 978 977 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @gauron99 , Please can you review this PR , If you have a moment. I got confuse that tests are failing in general or it is my issue ? becaues in that period I opened so many PRs and tests are failing in all PRs. |
|
Thanks for the PR @intojhanurag If this rerun of tests doesn't work, you can rebase /retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: intojhanurag, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc37630 to
be20318
Compare
|
Hey @gauron99 , pls this one also. last one :) |
|
/lgtm |
Previously, EnsureSecretExist only compared Secret.Data when deciding
whether to create or update a Kubernetes Secret. This caused updates
to be skipped if only labels or annotations changed, which could
break Knative function deployments relying on metadata.
Changes: