[release-1.21] Remember --registry-insecure setting on recurring runs#3574
Merged
knative-prow[bot] merged 3 commits intoknative:release-1.21from Apr 7, 2026
Merged
Conversation
…native#3484) When --registry-insecure is used, set tlsVerify=false in the Tekton pipeline to allow buildah to push to registries with self-signed certs.
* Revert "Pass --registry-insecure flag to Tekton pipeline tlsVerify parameter (knative#3484)" This reverts commit da21fa2. * Remember `--registry-insecure` setting on recurring runs * Run `make schema-generate` * Simplify parsing * Extend description of flag, that values are persited * Add warning, when registry changed but insecure-registry is still set to true * Fix typo * Rerun update-codegen * Cleanup test names * Add unit test for WarnRegistryInsecureChange * Run schema-generate * Update pkg/functions/client.go Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Update pkg/functions/client.go Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Update pkg/config/config.go Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Update pkg/config/config.go Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Fix format issues (goimport and gofmt) * Refactor registry-insecure unit test to make it available for the Deploy tests too * Refactor GlobalConfig.WarnRegistryInsecureChange() method to function in cmd package --------- Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com>
knative-prow
bot
added
the
size/XL
Member
Author
|
/cherry-pick release-1.20 |
|
@creydr: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
Author
|
/cc @gauron99 |
Contributor
|
@creydr pls regenerate docs |
Member
Author
Updated it. Sorry for the noise. It's green now |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
@creydr: #3574 failed to apply on top of branch "release-1.20": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
creydr
added a commit
to creydr/knative-func
that referenced
this pull request
Apr 7, 2026
…ns (knative#3574) * Pass --registry-insecure flag to Tekton pipeline tlsVerify parameter (knative#3484) When --registry-insecure is used, set tlsVerify=false in the Tekton pipeline to allow buildah to push to registries with self-signed certs. * Remember `--registry-insecure` setting on recurring runs (knative#3490) * Revert "Pass --registry-insecure flag to Tekton pipeline tlsVerify parameter (knative#3484)" This reverts commit da21fa2. * Remember `--registry-insecure` setting on recurring runs * Run `make schema-generate` * Simplify parsing * Extend description of flag, that values are persited * Add warning, when registry changed but insecure-registry is still set to true * Fix typo * Rerun update-codegen * Cleanup test names * Add unit test for WarnRegistryInsecureChange * Run schema-generate * Update pkg/functions/client.go Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Update pkg/functions/client.go Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Update pkg/config/config.go Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Update pkg/config/config.go Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Fix format issues (goimport and gofmt) * Refactor registry-insecure unit test to make it available for the Deploy tests too * Refactor GlobalConfig.WarnRegistryInsecureChange() method to function in cmd package --------- Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Ran `./hack/update-codegen.sh` --------- Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com>
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #3490