fix: Use tlsVerify param in PipelineRun template for pack too

[creydr]

Currently we use the tlsVerify param only in the pipeline arguments for the s2i pipelines. This leads to issues when on remote builds using insecure registries with the pack builder.
This PR addresses it and passes the tlsVerify arg to the pack PipelineRun too. When set, it sets the CNB_INSECURE_REGISTRIES env var before building the image.

[creydr]

/cc @matejvasek

[codecov]

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.24%. Comparing base (67c3fd2) to head (772825e).
⚠️ Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/pipelines/tekton/templates.go	64.28%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3575      +/-   ##
==========================================
+ Coverage   56.13%   56.24%   +0.10%     
==========================================
  Files         180      180              
  Lines       20465    20479      +14     
==========================================
+ Hits        11489    11519      +30     
+ Misses       7781     7759      -22     
- Partials     1195     1201       +6     

Flag	Coverage Δ
e2e	36.12% <35.71%> (+0.01%)	⬆️
e2e go	32.56% <50.00%> (+0.01%)	⬆️
e2e node	28.37% <50.00%> (+0.01%)	⬆️
e2e python	32.93% <50.00%> (+0.01%)	⬆️
e2e quarkus	28.52% <50.00%> (+0.03%)	⬆️
e2e rust	27.88% <50.00%> (-0.04%)	⬇️
e2e springboot	26.39% <50.00%> (+0.03%)	⬆️
e2e typescript	28.48% <50.00%> (-0.01%)	⬇️
e2e-config-ci	18.13% <0.00%> (?)
integration	17.44% <80.00%> (+0.02%)	⬆️
unit macos-14	43.36% <30.00%> (-0.01%)	⬇️
unit macos-latest	43.36% <30.00%> (-0.01%)	⬇️
unit ubuntu-24.04-arm	43.56% <28.57%> (-0.02%)	⬇️
unit ubuntu-latest	44.24% <30.00%> (-0.01%)	⬇️
unit windows-latest	43.38% <30.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[creydr]

/cherry-pick release-1.21
/cherry-pick release-1.20

[knative-prow-robot]

@creydr: once the present PR merges, I will cherry-pick it on top of release-1.20, release-1.21 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-1.21
/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gauron99]

thanks for the simplification. just one comment

[gauron99]

I think the new tls check is missing here? (createPipelineTemplatePAC function)

[gauron99]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [gauron99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@creydr: new pull request created: #3590

Details

In response to this:

/cherry-pick release-1.21
/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow-robot]

@creydr: #3575 failed to apply on top of branch "release-1.20":

Applying: Use tlsVerify param in Pipeline template for pack too
Using index info to reconstruct a base tree...
M	pkg/pipelines/tekton/templates_pack.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/pipelines/tekton/templates_pack.go
CONFLICT (content): Merge conflict in pkg/pipelines/tekton/templates_pack.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Use tlsVerify param in Pipeline template for pack too

Details

In response to this:

/cherry-pick release-1.21
/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.