tweak logging and fail fast

Author: dprotaso

test/e2e-tests.sh

@@ -81,7 +81,7 @@ fi
 for i in {1..20}; do
   export TEST_RUN=$i
   toggle_feature allow-zero-initial-scale true config-autoscaler || fail_test
-  go_test_e2e -timeout=2m ./test/e2e/initscale "${E2E_TEST_FLAGS[@]}" || failed=1
+  go_test_e2e -timeout=2m ./test/e2e/initscale "${E2E_TEST_FLAGS[@]}" || fail_test
   toggle_feature allow-zero-initial-scale false config-autoscaler || fail_test
 done
 

vendor/knative.dev/pkg/configmap/informer/informed_watcher.go

@@ -33,6 +33,7 @@ import (
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/tools/cache"
 	"knative.dev/pkg/configmap"
+	"knative.dev/pkg/kmap"
 )
 
 // NewInformedWatcherFromFactory watches a Kubernetes namespace for ConfigMap changes.
@@ -223,7 +224,8 @@ func (i *InformedWatcher) addConfigMapEvent(obj interface{}) {
 	i.OnChange(configMap)
 
 	if i.Logger != nil {
-		i.Logger.Warnf("config map %q added: %#v", configMap)
+		data := kmap.ExcludeKeyList(configMap.Data, []string{"_example"})
+		i.Logger.Warnf("config map %q added: %#v", configMap.Name, data)
 	}
 }
 
@@ -240,7 +242,8 @@ func (i *InformedWatcher) updateConfigMapEvent(o, n interface{}) {
 	}
 
 	if i.Logger != nil {
-		i.Logger.Warnf("config map %q updated: %#v", configMap)
+		data := kmap.ExcludeKeyList(configMap.Data, []string{"_example"})
+		i.Logger.Warnf("config map %q updated: %#v", configMap.Name, data)
 	}
 	i.OnChange(configMap)
 }
@@ -262,7 +265,8 @@ func (i *InformedWatcher) deleteConfigMapEvent(obj interface{}) {
 	}
 
 	if i.Logger != nil {
-		i.Logger.Warnf("config map %q deleted: %#v", configMap)
+		data := kmap.ExcludeKeyList(configMap.Data, []string{"_example"})
+		i.Logger.Warnf("config map %q deleted: %#v", configMap.Name, data)
 	}
 
 	if def, ok := i.defaults[configMap.Name]; ok {