Skip to content

Add support for service minscale annotation#16574

Open
Alexander-Kita wants to merge 7 commits intoknative:mainfrom
Alexander-Kita:service-minscale
Open

Add support for service minscale annotation#16574
Alexander-Kita wants to merge 7 commits intoknative:mainfrom
Alexander-Kita:service-minscale

Conversation

@Alexander-Kita
Copy link
Copy Markdown
Contributor

Fixes #14184

Proposed Changes

  • Add servicescaler controller that implements route reconciler to apply service minscale

Release Note

Adds service min scale capability

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Alexander-Kita
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 24, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 24, 2026

Hi @Alexander-Kita. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2026
@knative-prow knative-prow Bot requested review from dsimansk and skonto April 24, 2026 22:11
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.20%. Comparing base (7c94473) to head (3b6cf3d).

Files with missing lines Patch % Lines
pkg/reconciler/servicescaler/servicescaler.go 81.37% 10 Missing and 9 partials ⚠️
pkg/apis/autoscaling/v1alpha1/pa_lifecycle.go 0.00% 5 Missing and 1 partial ⚠️
pkg/testing/v1/route.go 0.00% 5 Missing ⚠️
pkg/apis/serving/metadata_validation.go 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16574      +/-   ##
==========================================
- Coverage   80.36%   80.20%   -0.17%     
==========================================
  Files         217      219       +2     
  Lines       17305    13709    -3596     
==========================================
- Hits        13907    10995    -2912     
+ Misses       3035     2340     -695     
- Partials      363      374      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Copy Markdown
Member

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service level minScale

2 participants