refactor: github pr context.

Author: knightedcodemonkey

playwright/github-byot-ai.spec.ts

@@ -1,5 +1,5 @@
 import { expect, test } from '@playwright/test'
-import { defaultGitHubChatModel } from '../src/modules/github/github-api.js'
+import { defaultGitHubChatModel } from '../src/modules/github/api/chat.js'
 import type { ChatRequestBody, ChatRequestMessage } from './helpers/app-test-helpers.js'
 import {
   appEntryPath,

playwright/workspace-tabs.spec.ts

@@ -108,6 +108,62 @@ const seedSyncedComponentTab = async (page: import('@playwright/test').Page) =>
   })
 }
 
+const waitForWorkspaceTabOrderPersistence = async (
+  page: import('@playwright/test').Page,
+  expectedLeadingTabNames: string[],
+) => {
+  await expect
+    .poll(async () => {
+      return page.evaluate(async expectedTabNames => {
+        const request = indexedDB.open('knighted-develop-workspaces')
+
+        const db = await new Promise<IDBDatabase>((resolve, reject) => {
+          request.onsuccess = () => resolve(request.result)
+          request.onerror = () => reject(request.error)
+          request.onblocked = () => reject(new Error('Could not open IndexedDB.'))
+        })
+
+        try {
+          const tx = db.transaction('prWorkspaces', 'readonly')
+          const store = tx.objectStore('prWorkspaces')
+          const getAllRequest = store.getAll()
+
+          const records = await new Promise<Array<Record<string, unknown>>>(
+            (resolve, reject) => {
+              getAllRequest.onsuccess = () => {
+                const value = Array.isArray(getAllRequest.result)
+                  ? getAllRequest.result
+                  : []
+                resolve(value as Array<Record<string, unknown>>)
+              }
+              getAllRequest.onerror = () => reject(getAllRequest.error)
+            },
+          )
+
+          return records.some(record => {
+            const tabs = Array.isArray(record.tabs) ? record.tabs : []
+            const tabNames = tabs
+              .map(tab => {
+                if (!tab || typeof tab !== 'object') {
+                  return ''
+                }
+
+                return typeof (tab as { name?: unknown }).name === 'string'
+                  ? ((tab as { name: string }).name ?? '')
+                  : ''
+              })
+              .filter(name => name.length > 0)
+
+            return expectedTabNames.every((name, index) => tabNames[index] === name)
+          })
+        } finally {
+          db.close()
+        }
+      }, expectedLeadingTabNames)
+    })
+    .toBe(true)
+}
+
 test('removing active tab selects deterministic adjacent tab', async ({ page }) => {
   await waitForInitialRender(page)
 
@@ -320,8 +376,8 @@ test('workspace tab drag reorder persists across reload', async ({ page }) => {
   await expect(orderedTabs.nth(0)).toHaveAccessibleName('Workspace tab module-2.tsx')
   await expect(orderedTabs.nth(1)).toHaveAccessibleName('Workspace tab App.tsx')
 
-  /* Reorder persistence is debounced; wait for normal save rather than unload flush. */
-  await page.waitForTimeout(1000)
+  /* Reorder persistence is debounced; wait until IndexedDB reflects the new order. */
+  await waitForWorkspaceTabOrderPersistence(page, ['module-2.tsx', 'App.tsx'])
 
   await page.reload()
   await waitForInitialRender(page)

src/app.js

@@ -41,14 +41,14 @@ import { createWorkspaceSyncController } from './modules/app-core/workspace-sync
 import { createWorkspaceTabAddMenuUiController } from './modules/app-core/workspace-tab-add-menu-ui.js'
 import { createDiagnosticsUiController } from './modules/diagnostics/diagnostics-ui.js'
 import { createGitHubChatDrawer } from './modules/github/chat-drawer/drawer.js'
-import { createGitHubByotControls } from './modules/github/github-byot-controls.js'
+import { createGitHubByotControls } from './modules/github/byot-controls.js'
 import {
   formatActivePrReference,
   getActivePrContextSyncKey,
   parsePullRequestNumberFromUrl,
-} from './modules/github/github-pr-context.js'
-import { createGitHubPrEditorSyncController } from './modules/github/github-pr-editor-sync.js'
-import { createGitHubPrDrawer } from './modules/github/github-pr-drawer.js'
+} from './modules/github/pr/context.js'
+import { createGitHubPrEditorSyncController } from './modules/github/pr/editor-sync.js'
+import { createGitHubPrDrawer } from './modules/github/pr/drawer/controller/create-controller.js'
 import { createLayoutThemeController } from './modules/ui/layout-theme.js'
 import { createLintDiagnosticsController } from './modules/diagnostics/lint-diagnostics.js'
 import { createPreviewBackgroundController } from './modules/preview/preview-background.js'