refactor: address pr comments.

Author: knightedcodemonkey

docs/localstorage-state.md

@@ -8,18 +8,17 @@ This document is the source of truth for what `@knighted/develop` stores in `loc
 
 1. `knighted:develop:github-pat`
    - GitHub personal access token used for API calls.
-2. `knighted:develop:github-repository`
-   - Last selected repository full name (for example: `owner/repo`).
-3. `knighted-develop:render-mode`
+2. `knighted-develop:render-mode`
    - Last selected render mode (`dom` or `react`).
-4. Theme/UI preference keys managed by layout theme modules.
+3. Theme/UI preference keys managed by layout theme modules.
 
 ## Not Allowed In localStorage
 
 Do not store pull request context in `localStorage`.
 
 Examples that must stay out of `localStorage`:
 
+- Selected repository preference (`owner/repo`)
 - PR context state (`active`, `disconnected`, `closed`, `inactive`)
 - PR number and URL
 - PR base/head/title/body
@@ -31,3 +30,5 @@ Examples that must stay out of `localStorage`:
 `localStorage` is for lightweight bootstrap preferences only.
 
 If data is needed to restore workspace or pull request workflow state, it belongs in IndexedDB workspace records.
+
+Repository selection is derived from in-memory BYOT controls and IndexedDB-backed workspace records, not from a dedicated localStorage key.

playwright/github-pr-drawer/open-pr-create.spec.ts

@@ -445,36 +445,6 @@ test('Open PR success normalizes trailing newline without showing Edited indicat
   expect(String(stylesBlob?.content).endsWith('\n')).toBe(true)
 })
 
-test('Open PR drawer can filter stored local contexts by search', async ({ page }) => {
-  await waitForAppReady(page, `${appEntryPath}`)
-
-  await seedLocalWorkspaceContexts(page, [
-    {
-      id: 'repo_knightedcodemonkey_develop_feat-alpha',
-      repo: 'knightedcodemonkey/develop',
-      head: 'feat/alpha',
-      prTitle: 'Alpha local context',
-    },
-    {
-      id: 'repo_knightedcodemonkey_develop_feat-beta',
-      repo: 'knightedcodemonkey/develop',
-      head: 'feat/beta',
-      prTitle: 'Beta local context',
-    },
-  ])
-
-  await connectByotWithSingleRepo(page)
-  await page.getByRole('button', { name: 'Workspaces' }).click()
-  await page.getByLabel('Workspace repository filter').selectOption('__local__')
-
-  const search = page.getByLabel('Search stored local contexts')
-  await expect(search).toBeEnabled()
-  await search.fill('beta')
-
-  const labels = await getLocalContextOptionLabels(page)
-  expect(labels).toEqual(['Select a stored local context', 'local:Beta local context'])
-})
-
 test('Workspaces repository selector filters contexts and keeps local-only contexts under Local', async ({
   page,
 }) => {

src/app.js

@@ -141,7 +141,6 @@ const workspacesDrawer = document.getElementById('workspaces-drawer')
 const workspacesClose = document.getElementById('workspaces-close')
 const workspacesStatus = document.getElementById('workspaces-status')
 const workspacesRepository = document.getElementById('workspaces-repository')
-const workspacesSearch = document.getElementById('workspaces-search')
 const workspacesSelect = document.getElementById('workspaces-select')
 const workspacesOpen = document.getElementById('workspaces-open')
 const workspacesRemove = document.getElementById('workspaces-remove')
@@ -1066,7 +1065,6 @@ const githubWorkflows = createGitHubWorkflowsSetup({
     workspacesClose,
     workspacesStatus,
     workspacesRepository,
-    workspacesSearch,
     workspacesSelect,
     workspacesOpen,
     workspacesRemove,

src/index.html

@@ -822,18 +822,6 @@ <h2 id="workspaces-title">Workspaces</h2>
             </select>
           </label>
 
-          <label class="github-pr-field github-pr-field--full" for="workspaces-search">
-            <span>Search local contexts</span>
-            <input
-              id="workspaces-search"
-              type="search"
-              autocomplete="off"
-              spellcheck="false"
-              placeholder="Search local contexts"
-              aria-label="Search stored local contexts"
-            />
-          </label>
-
           <label class="github-pr-field github-pr-field--full" for="workspaces-select">
             <span>Stored contexts</span>
             <select id="workspaces-select" aria-label="Stored local editor contexts">

src/modules/app-core/github-workflows.js

@@ -1,3 +1,5 @@
+import { repositoryStarterSelectionIdPrefix } from '../constants.js'
+
 const initializeGitHubWorkflows = ({
   createGitHubPrEditorSyncController,
   createGitHubChatDrawer,
@@ -40,7 +42,6 @@ const initializeGitHubWorkflows = ({
   workspacesClose,
   workspacesStatus,
   workspacesRepository,
-  workspacesSearch,
   workspacesSelect,
   workspacesOpen,
   workspacesRemove,
@@ -101,8 +102,6 @@ const initializeGitHubWorkflows = ({
     return collectTopLevelDeclarations({ source, transformJsxSource })
   }
 
-  const repositoryStarterSelectionIdPrefix = '__create_repository_context__:'
-
   const parseRepositoryStarterSelectionId = value => {
     const normalizedValue = typeof value === 'string' ? value.trim() : ''
     if (!normalizedValue.startsWith(repositoryStarterSelectionIdPrefix)) {
@@ -316,7 +315,6 @@ const initializeGitHubWorkflows = ({
     closeButton: workspacesClose,
     statusNode: workspacesStatus,
     repositorySelect: workspacesRepository,
-    searchInput: workspacesSearch,
     selectInput: workspacesSelect,
     openButton: workspacesOpen,
     removeButton: workspacesRemove,

src/modules/constants.js

@@ -0,0 +1 @@
+export const repositoryStarterSelectionIdPrefix = '__create_repository_context__:'

src/modules/workspace/workspaces-drawer/drawer.js

@@ -1,20 +1,20 @@
+import { repositoryStarterSelectionIdPrefix } from '../../constants.js'
+
 const toSafeText = value => (typeof value === 'string' ? value.trim() : '')
 
-const normalizeQuery = value => toSafeText(value).toLowerCase()
 const localRepositoryFilterValue = '__local__'
-const createRepositoryStarterIdPrefix = '__create_repository_context__:'
 
 const toRepositoryStarterSelectionId = repositoryFullName => {
   const repository = toSafeText(repositoryFullName)
   if (!repository || repository === localRepositoryFilterValue) {
     return ''
   }
 
-  return `${createRepositoryStarterIdPrefix}${repository}`
+  return `${repositoryStarterSelectionIdPrefix}${repository}`
 }
 
 const isRepositoryStarterSelectionId = value =>
-  toSafeText(value).startsWith(createRepositoryStarterIdPrefix)
+  toSafeText(value).startsWith(repositoryStarterSelectionIdPrefix)
 
 const isLocalWorkspaceEntry = workspace => {
   const repository = toSafeText(workspace?.repo)
@@ -44,34 +44,12 @@ const toWorkspaceLabel = workspace => {
   return isLocalOnlyInactive ? `local:${fallbackLabel}` : fallbackLabel
 }
 
-const matchesQuery = (workspace, query) => {
-  if (!query) {
-    return true
-  }
-
-  const haystack = [
-    workspace?.id,
-    workspace?.repo,
-    workspace?.base,
-    workspace?.head,
-    workspace?.prTitle,
-    toWorkspaceLabel(workspace),
-  ]
-    .map(toSafeText)
-    .filter(Boolean)
-    .join(' ')
-    .toLowerCase()
-
-  return haystack.includes(query)
-}
-
 export const createWorkspacesDrawer = ({
   toggleButton,
   drawer,
   closeButton,
   statusNode,
   repositorySelect,
-  searchInput,
   selectInput,
   openButton,
   removeButton,
@@ -85,7 +63,6 @@ export const createWorkspacesDrawer = ({
 } = {}) => {
   let open = false
   let entries = []
-  let query = ''
   let selectedId = ''
   let selectedRepositoryFilter = localRepositoryFilterValue
   let hasUserSelectedRepositoryFilter = false
@@ -147,9 +124,7 @@ export const createWorkspacesDrawer = ({
     }
 
     const repositoryFilteredEntries = getFilteredEntriesByRepository()
-    const filteredEntries = repositoryFilteredEntries.filter(entry =>
-      matchesQuery(entry, normalizeQuery(query)),
-    )
+    const filteredEntries = repositoryFilteredEntries
     const normalizedRepositoryFilter = getNormalizedRepositoryFilter(
       selectedRepositoryFilter,
     )
@@ -168,9 +143,7 @@ export const createWorkspacesDrawer = ({
         ? hasStarterSelection
           ? 'Select to start a new local context'
           : 'No saved local contexts'
-        : filteredEntries.length > 0
-          ? 'Select a stored local context'
-          : 'No matching local contexts'
+        : 'Select a stored local context'
     placeholder.disabled = filteredEntries.length > 0 || hasStarterSelection
     placeholder.selected = !filteredEntries.some(entry => entry.id === selectedId)
     selectInput.append(placeholder)
@@ -191,10 +164,6 @@ export const createWorkspacesDrawer = ({
       selectInput.append(option)
     }
 
-    if (searchInput instanceof HTMLInputElement) {
-      searchInput.disabled = repositoryFilteredEntries.length === 0
-    }
-
     const hasSelectedFilteredEntry = filteredEntries.some(
       entry => entry.id === selectedId,
     )
@@ -329,11 +298,6 @@ export const createWorkspacesDrawer = ({
       return
     }
 
-    if (searchInput instanceof HTMLInputElement && !searchInput.disabled) {
-      searchInput.focus()
-      return
-    }
-
     selectInput?.focus()
   }
 
@@ -345,24 +309,14 @@ export const createWorkspacesDrawer = ({
     void setOpen(false)
   })
 
-  searchInput?.addEventListener('input', () => {
-    query = searchInput.value
-    renderOptions()
-  })
-
   repositorySelect?.addEventListener('change', async () => {
     selectedRepositoryFilter = getNormalizedRepositoryFilter(repositorySelect.value)
     hasUserSelectedRepositoryFilter = true
-    query = ''
 
     if (typeof onRepositoryFilterChange === 'function') {
       await onRepositoryFilterChange(selectedRepositoryFilter)
     }
 
-    if (searchInput instanceof HTMLInputElement) {
-      searchInput.value = ''
-    }
-
     await refresh({ preserveSelection: false })
   })
 

src/styles/ai-controls.css

@@ -722,14 +722,6 @@
   grid-column: 1 / -1;
 }
 
-.github-pr-field--local-context {
-  gap: 8px;
-}
-
-.github-pr-field--local-context input[type='search'] {
-  width: 100%;
-}
-
 .github-pr-local-context-row {
   display: grid;
   grid-template-columns: minmax(0, 1fr) auto;