refactor: cleaner code paths.

Author: knightedcodemonkey

src/app.js

@@ -685,7 +685,6 @@ const syncAiChatTokenVisibility = token => {
 }
 
 const byotControls = createGitHubByotControls({
-  featureEnabled: true,
   controlsRoot: githubAiControls,
   tokenInput: githubTokenInput,
   tokenInfoButton: githubTokenInfo,
@@ -788,7 +787,6 @@ chatDrawerController = createGitHubChatDrawer({
 })
 
 prDrawerController = createGitHubPrDrawer({
-  featureEnabled: true,
   toggleButton: githubPrToggle,
   drawer: githubPrDrawer,
   closeButton: githubPrClose,

src/modules/github-byot-controls.js

@@ -48,7 +48,6 @@ const createDefaultRepoOption = ({
 }
 
 export const createGitHubByotControls = ({
-  featureEnabled,
   controlsRoot,
   tokenInput,
   tokenInfoButton,
@@ -61,16 +60,6 @@ export const createGitHubByotControls = ({
   onTokenChange,
   setStatus,
 }) => {
-  if (!featureEnabled) {
-    controlsRoot?.setAttribute('hidden', '')
-    return {
-      getSelectedRepository: () => null,
-      getWritableRepositories: () => [],
-      setSelectedRepository: () => false,
-      getToken: () => null,
-    }
-  }
-
   let savedToken = loadGitHubToken()
   let currentRepoRequestAbortController = null
   let displayingMaskedToken = false

src/modules/github-pr-drawer.js

@@ -398,7 +398,6 @@ const stripTopLevelAppWrapper = async ({ source, getTopLevelDeclarations }) => {
 }
 
 export const createGitHubPrDrawer = ({
-  featureEnabled,
   toggleButton,
   drawer,
   closeButton,
@@ -432,23 +431,6 @@ export const createGitHubPrDrawer = ({
   onRestoreRenderMode,
   onRestoreStyleMode,
 }) => {
-  if (!featureEnabled) {
-    toggleButton?.setAttribute('hidden', '')
-    drawer?.setAttribute('hidden', '')
-
-    return {
-      setOpen: () => {},
-      isOpen: () => false,
-      setToken: () => {},
-      setSelectedRepository: () => {},
-      getActivePrContext: () => null,
-      clearActivePrContext: () => {},
-      closeActivePullRequestOnGitHub: async () => null,
-      syncRepositories: () => {},
-      dispose: () => {},
-    }
-  }
-
   let open = false
   let submitting = false
   let pendingAbortController = null