refactor: remove local storage logic for render mode.

Author: knightedcodemonkey

src/app.js

@@ -14,11 +14,9 @@ import {
 import { createDiagnosticsFlowController } from './modules/app-core/diagnostics-flow-controller.js'
 import { createEditorBootstrapController } from './modules/app-core/editor-bootstrap-controller.js'
 import {
-  getInitialRenderMode as getInitialRenderModeValue,
   getStyleEditorLanguage,
   normalizeRenderMode,
   normalizeStyleMode,
-  persistRenderMode as persistRenderModeValue,
   setCssSourceValue,
   setJsxSourceValue,
   updateRenderModeEditability as updateRenderModeEditabilityValue,
@@ -214,7 +212,6 @@ const defaultStylesTabPath = 'src/styles/app.css'
 const defaultComponentTabName = 'App.tsx'
 const defaultStylesTabName = 'app.css'
 const allowedEntryTabFileNames = new Set(['app.tsx', 'app.js'])
-const renderModeStorageKey = 'knighted-develop:render-mode'
 const editorKinds = ['component', 'styles']
 const editorPanelsByKind = {
   component: componentEditorPanel,
@@ -762,7 +759,6 @@ const {
   setRenderModeValue: value => {
     renderMode.value = value
   },
-  persistRenderMode: mode => persistRenderMode(mode),
   getActiveWorkspaceTab,
   onActiveWorkspaceTabChange: (_tab, { changed } = {}) => {
     syncDiagnosticsDrawerLayout()
@@ -1205,9 +1201,7 @@ chatDrawerController = githubWorkflows.chatDrawerController
 prDrawerController = githubWorkflows.prDrawerController
 workspacesDrawerController = githubWorkflows.workspacesDrawerController
 
-const persistRenderMode = mode => persistRenderModeValue(mode, { renderModeStorageKey })
-
-const getInitialRenderMode = () => getInitialRenderModeValue({ renderModeStorageKey })
+const getInitialRenderMode = () => 'dom'
 
 const updateRenderModeEditability = () =>
   updateRenderModeEditabilityValue({ renderMode, getActiveWorkspaceTab })
@@ -1295,7 +1289,6 @@ const runtimeCoreOptions = createRuntimeCoreOptions({
   setPendingClearAction: value => (pendingClearAction = value),
   normalizeRenderMode,
   normalizeStyleMode,
-  persistRenderMode,
   resetDiagnosticsFlow: () => diagnosticsFlowController.resetDiagnosticsFlow(),
   maybeRender: () => diagnosticsFlowController.maybeRender(),
   flushWorkspaceSave,

src/modules/app-core/app-composition-options.js

@@ -44,7 +44,6 @@ const createRuntimeCoreOptions = ({
   setPendingClearAction,
   normalizeRenderMode,
   normalizeStyleMode,
-  persistRenderMode,
   resetDiagnosticsFlow,
   maybeRender,
   flushWorkspaceSave,
@@ -111,7 +110,6 @@ const createRuntimeCoreOptions = ({
   setPendingClearAction,
   normalizeRenderMode,
   normalizeStyleMode,
-  persistRenderMode,
   resetDiagnosticsFlow,
   maybeRender,
   flushWorkspaceSave,

src/modules/app-core/runtime-core-setup.js

@@ -10,7 +10,6 @@ const createRuntimeCoreSetup = ({
   setPendingClearAction,
   normalizeRenderMode,
   normalizeStyleMode,
-  persistRenderMode,
   resetDiagnosticsFlow,
   maybeRender,
   flushWorkspaceSave,
@@ -99,7 +98,7 @@ const createRuntimeCoreSetup = ({
       renderMode.value = nextMode
     }
 
-    persistRenderMode(nextMode)
+    queueWorkspaceSave()
     resetDiagnosticsFlow()
 
     maybeRender()

src/modules/app-core/runtime-editor-utils.js

@@ -6,27 +6,6 @@ const getStyleEditorLanguage = mode => {
 
 const normalizeRenderMode = mode => (mode === 'react' ? 'react' : 'dom')
 
-const persistRenderMode = (mode, { renderModeStorageKey }) => {
-  const normalizedMode = normalizeRenderMode(mode)
-
-  try {
-    localStorage.setItem(renderModeStorageKey, normalizedMode)
-  } catch {
-    /* Ignore storage write errors in restricted browsing modes. */
-  }
-}
-
-const getInitialRenderMode = ({ renderModeStorageKey }) => {
-  try {
-    const value = localStorage.getItem(renderModeStorageKey)
-    return normalizeRenderMode(value)
-  } catch {
-    /* Ignore storage read errors in restricted browsing modes. */
-  }
-
-  return 'dom'
-}
-
 const updateRenderModeEditability = ({ renderMode, getActiveWorkspaceTab }) => {
   if (!(renderMode instanceof HTMLSelectElement)) {
     return
@@ -79,11 +58,9 @@ const setCssSourceValue = ({
 }
 
 export {
-  getInitialRenderMode,
   getStyleEditorLanguage,
   normalizeRenderMode,
   normalizeStyleMode,
-  persistRenderMode,
   setCssSourceValue,
   setJsxSourceValue,
   updateRenderModeEditability,

src/modules/app-core/workspace-context-controller.js

@@ -19,7 +19,6 @@ const createWorkspaceContextController = ({
   normalizeRenderMode,
   getRenderModeValue,
   setRenderModeValue,
-  persistRenderMode,
   onWorkspaceRecordApplied,
   getActiveWorkspaceTab,
   loadWorkspaceTabIntoEditor,
@@ -129,7 +128,6 @@ const createWorkspaceContextController = ({
       if (getRenderModeValue() !== nextRenderMode) {
         setRenderModeValue(nextRenderMode)
       }
-      persistRenderMode(nextRenderMode)
 
       const activeTab = getActiveWorkspaceTab()
       if (activeTab) {

src/modules/app-core/workspace-controllers-setup.js

@@ -30,7 +30,6 @@ const createWorkspaceControllersSetup = ({
   normalizeRenderMode,
   getRenderModeValue,
   setRenderModeValue,
-  persistRenderMode,
   onWorkspaceRecordApplied,
   getActiveWorkspaceTab,
   onActiveWorkspaceTabChange,
@@ -220,7 +219,6 @@ const createWorkspaceControllersSetup = ({
     normalizeRenderMode,
     getRenderModeValue,
     setRenderModeValue,
-    persistRenderMode,
     onWorkspaceRecordApplied,
     getActiveWorkspaceTab,
     loadWorkspaceTabIntoEditor,