fix: workspace identity on changing for same repo.

Author: knightedcodemonkey

docs/idb-workspace-state.md

@@ -17,6 +17,7 @@ Each workspace record may include:
   - `id`
   - `createdAt`
   - `lastModified`
+  - `workspaceScope` (`local` | `repository`)
 - Repository and PR context:
   - `repo`
   - `base`
@@ -44,3 +45,9 @@ IDB supports that by storing:
 If a value is required to accurately restore PR/workspace behavior after reload, it must live in IDB records.
 
 `localStorage` should only mirror user preferences and lightweight bootstrap values.
+
+## Behavioral Spec
+
+For action-level drawer semantics and state machine behavior, see:
+
+- `docs/workspaces-behavior-algorithm.md`

docs/localstorage-state.md

@@ -32,3 +32,7 @@ Examples that must stay out of `localStorage`:
 If data is needed to restore workspace or pull request workflow state, it belongs in IndexedDB workspace records.
 
 Repository selection is derived from in-memory BYOT controls and IndexedDB-backed workspace records, not from a dedicated localStorage key.
+
+For the Workspaces drawer action/state algorithm, see:
+
+- `docs/workspaces-behavior-algorithm.md`

docs/workspaces-behavior-algorithm.md

@@ -0,0 +1,96 @@
+# Workspaces Drawer Behavior Algorithm
+
+This document locks in the intended behavior for Workspaces drawer actions.
+
+## Goals
+
+- Keep action semantics explicit and predictable.
+- Keep button visibility state-driven and mutually exclusive.
+- Preserve workspace restore behavior by persisting state in IndexedDB.
+
+## Core Terms
+
+- `Local` scope: Workspaces whose `workspaceScope` is `local`.
+- `Repository` scope: Workspaces whose `workspaceScope` is `repository` and whose `repo` matches the selected repository filter.
+- `workspaceKey`: Derived identity key from repository + head branch. Used for matching/preference logic, not for UI policy by itself.
+
+## Required Invariants
+
+1. `Initialize` and `New workspace` must never be visible at the same time.
+2. `Local` scope never shows `Initialize`.
+3. `Initialize` for non-Local empty scope updates the active workspace in place (no fork).
+4. `New workspace` always forks from current editor/runtime state into a new record id.
+5. Fork creation must generate a fresh head branch suffix so `workspaceKey` and visible labels are distinct.
+6. Any workspace created via `New workspace` must persist with `prContextState = "inactive"`.
+7. For `New workspace`, `workspaceScope` is target-dependent:
+   - `local` when repository filter is `__local__`
+   - `repository` when repository filter is a non-local `owner/repo`
+
+## UI State Machine
+
+State is derived from:
+
+- Selected repository filter (`__local__` vs non-local `owner/repo`)
+- Presence of stored workspaces in the selected scope
+
+States:
+
+1. `local-empty`
+   - Show: `New workspace`
+   - Hide: `Initialize`, workspace select, `Open`, `Remove`
+2. `local-with-workspaces`
+   - Show: `New workspace`, workspace select, `Open`, `Remove`
+   - Hide: `Initialize`
+3. `repository-empty`
+   - Show: `Initialize`
+   - Hide: `New workspace`, workspace select, `Open`, `Remove`
+4. `repository-with-workspaces`
+   - Show: `New workspace`, workspace select, `Open`, `Remove`
+   - Hide: `Initialize`
+
+## Action Semantics
+
+### A) Local + New workspace
+
+- Action: fork current workspace into a new record.
+- Persisted updates:
+  - `workspaceScope = "local"`
+  - `prContextState = "inactive"`
+  - `repo = ""`
+  - fresh `id`
+  - fresh local `head` (suffix-appended)
+  - `workspaceKey = local::<fresh-head>`
+
+### B) Non-Local + Initialize (no stored workspaces in selected repository)
+
+- Action: update active workspace in place to selected repository scope.
+- Persisted updates on current record:
+  - `workspaceScope = "repository"`
+  - `repo = <selected owner/repo>`
+  - `workspaceKey = <selected owner/repo>::<current head>`
+- Must preserve current record id.
+
+### C) Non-Local + New workspace (stored workspaces exist)
+
+- Action: fork current workspace into a new repository-scoped record.
+- Persisted updates:
+  - `workspaceScope = "repository"`
+  - `prContextState = "inactive"`
+  - `repo = <selected owner/repo>`
+  - fresh `id`
+  - fresh repository `head` (suffix-appended from current head)
+  - `workspaceKey = <selected owner/repo>::<head>`
+
+## Storage Notes
+
+- Canonical workflow state lives in IndexedDB (`prWorkspaces` records).
+- `localStorage` must not own repository/workspace workflow state.
+
+## Regression Coverage Expectations
+
+At minimum, tests should verify:
+
+1. Local `New workspace` creates a new record and distinct local label/key.
+2. Non-local empty scope shows only `Initialize` and updates active record in place.
+3. Non-local scope with records shows only `New workspace` and forks new record.
+4. `Initialize` and `New workspace` never coexist.

playwright/github-byot-ai.spec.ts

@@ -768,17 +768,16 @@ test('BYOT remembers selected repository across reloads', async ({ page }) => {
 
   await page.getByRole('button', { name: 'Workspaces' }).click()
   const workspaceRepositoryFilter = page.getByLabel('Workspace repository filter')
-  const newWorkspaceButton = page.getByRole('button', {
-    name: 'New workspace',
+  const initializeButton = page.getByRole('button', {
+    name: 'Initialize',
     exact: true,
   })
   await expect(workspaceRepositoryFilter).toBeVisible()
   await workspaceRepositoryFilter.selectOption('knightedcodemonkey/develop')
   await expect(workspaceRepositoryFilter).toHaveValue('knightedcodemonkey/develop')
 
-  await expect(newWorkspaceButton).toBeVisible()
-  await newWorkspaceButton.click()
-  await page.getByRole('button', { name: 'Close workspaces drawer' }).click()
+  await expect(initializeButton).toBeVisible()
+  await initializeButton.click()
 
   await ensureOpenPrDrawerOpen(page)
   await expect(repoSelect).toHaveValue('knightedcodemonkey/develop')