refactor: address pr comments.

Author: knightedcodemonkey

playwright/github-byot-ai.spec.ts

@@ -395,9 +395,21 @@ test('deleting saved GitHub token requires confirmation modal', async ({ page })
   const tokenDelete = page.getByRole('button', { name: 'Delete GitHub token' })
   const tokenAdd = page.getByRole('button', { name: 'Add GitHub token' })
   const tokenInput = page.getByRole('textbox', { name: 'GitHub token' })
+  const workspacesToggle = page.getByRole('button', {
+    name: 'Workspaces',
+    exact: true,
+  })
+  const repositoryFilter = page.getByRole('combobox', {
+    name: 'Workspace repository filter',
+  })
 
   await expect(tokenDelete).toBeVisible()
 
+  await workspacesToggle.click()
+  await expect(repositoryFilter).toBeEnabled()
+  await repositoryFilter.selectOption('knightedcodemonkey/develop')
+  await expect(repositoryFilter).toHaveValue('knightedcodemonkey/develop')
+
   await tokenDelete.click()
   await expect(dialog).toHaveAttribute('open', '')
   await expect(page.getByText('Remove saved GitHub token?', { exact: true })).toHaveText(
@@ -430,6 +442,12 @@ test('deleting saved GitHub token requires confirmation modal', async ({ page })
   await expect(tokenAdd).toBeVisible()
   await expect(tokenDelete).toBeHidden()
   await expect(tokenInput).toHaveValue('')
+  await expect(workspacesToggle).toHaveAttribute('aria-expanded', 'false')
+  await expect(page.getByRole('complementary', { name: 'Workspaces' })).toBeHidden()
+
+  await workspacesToggle.click()
+  await expect(repositoryFilter).toBeDisabled()
+  await expect(repositoryFilter).toHaveValue('__local__')
 })
 
 test('AI chat drawer opens and closes', async ({ page }) => {

src/app.js

@@ -498,6 +498,9 @@ const prContextUi = createGitHubPrContextUiController({
   closePrDrawer: () => {
     prDrawerController.setOpen(false)
   },
+  closeWorkspacesDrawer: () => {
+    void workspacesDrawerController?.setOpen(false)
+  },
 })
 
 const editedIndicatorVisibilityController = createEditedIndicatorVisibilityController({

src/index.html

@@ -214,7 +214,7 @@ <h1>
               type="button"
               aria-expanded="false"
               aria-controls="workspaces-drawer"
-              title="Manage local workspaces"
+              title="Manage workspaces"
             >
               <svg class="workspaces-toggle__icon" viewBox="0 0 24 24" aria-hidden="true">
                 <path

src/modules/app-core/github-pr-context-ui.js

@@ -15,6 +15,7 @@ export const createGitHubPrContextUiController = ({
   githubPrPushCommitIcon,
   closeChatDrawer,
   closePrDrawer,
+  closeWorkspacesDrawer,
 }) => {
   const setGitHubPrToggleVisual = mode => {
     if (
@@ -134,6 +135,7 @@ export const createGitHubPrContextUiController = ({
     githubPrContextClose?.setAttribute('hidden', '')
     closeChatDrawer?.()
     closePrDrawer?.()
+    closeWorkspacesDrawer?.()
   }
 
   return {